Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1165283003:
vs2015: fix rename of _crt_va_start (Closed)
|
Created:
5 years, 6 months ago by scottmg Modified:
5 years, 6 months ago CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@2015-vp8-unittest Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionvs2015: fix rename of _crt_va_start
d:\src\cr3\src\sandbox\win\sandbox_poc\main_ui_window.cc(627): error C3861: '_crt_va_start': identifier not found
R=jschuh@chromium.org
BUG=440500
Committed: https://crrev.com/85709cb0b754fd92efe6ea0de2da3b4a875db40f
Cr-Commit-Position: refs/heads/master@{#333389}
Patch Set 1 #
Total comments: 4
Messages
Total messages: 16 (4 generated)
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165283003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165283003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/85709cb0b754fd92efe6ea0de2da3b4a875db40f Cr-Commit-Position: refs/heads/master@{#333389}
Message was sent while issue was closed.
rnk@chromium.org changed reviewers: + rnk@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/1165283003/diff/1/sandbox/win/sandbox_poc/mai... File sandbox/win/sandbox_poc/main_ui_window.cc (right): https://codereview.chromium.org/1165283003/diff/1/sandbox/win/sandbox_poc/mai... sandbox/win/sandbox_poc/main_ui_window.cc:628: __crt_va_start(arg_list, format); Why not va_start from <stdarg.h>?
Message was sent while issue was closed.
https://codereview.chromium.org/1165283003/diff/1/sandbox/win/sandbox_poc/mai... File sandbox/win/sandbox_poc/main_ui_window.cc (right): https://codereview.chromium.org/1165283003/diff/1/sandbox/win/sandbox_poc/mai... sandbox/win/sandbox_poc/main_ui_window.cc:628: __crt_va_start(arg_list, format); On 2015/06/09 00:37:59, Reid Kleckner wrote: > Why not va_start from <stdarg.h>? No idea, it seemed strange enough that I left it alone, but I meant to ask too. Justin, any reason that you know of?
Message was sent while issue was closed.
https://codereview.chromium.org/1165283003/diff/1/sandbox/win/sandbox_poc/mai... File sandbox/win/sandbox_poc/main_ui_window.cc (right): https://codereview.chromium.org/1165283003/diff/1/sandbox/win/sandbox_poc/mai... sandbox/win/sandbox_poc/main_ui_window.cc:628: __crt_va_start(arg_list, format); On 2015/06/09 16:27:43, scottmg wrote: > On 2015/06/09 00:37:59, Reid Kleckner wrote: > > Why not va_start from <stdarg.h>? > > No idea, it seemed strange enough that I left it alone, but I meant to ask too. > > Justin, any reason that you know of? Hmm, attributed to one "initial.commit" so I'm guessing just random crazy long-ago-sandbox-hacker. I'll switch it.
Message was sent while issue was closed.
https://codereview.chromium.org/1165283003/diff/1/sandbox/win/sandbox_poc/mai... File sandbox/win/sandbox_poc/main_ui_window.cc (right): https://codereview.chromium.org/1165283003/diff/1/sandbox/win/sandbox_poc/mai... sandbox/win/sandbox_poc/main_ui_window.cc:628: __crt_va_start(arg_list, format); On 2015/06/09 16:28:28, scottmg wrote: > On 2015/06/09 16:27:43, scottmg wrote: > > On 2015/06/09 00:37:59, Reid Kleckner wrote: > > > Why not va_start from <stdarg.h>? > > > > No idea, it seemed strange enough that I left it alone, but I meant to ask > too. > > > > Justin, any reason that you know of? > > Hmm, attributed to one "initial.commit" so I'm guessing just random crazy > long-ago-sandbox-hacker. I'll switch it. and va_start is #defined to [_]_crt_va_start (as you probably already knew) so seems silly. https://codereview.chromium.org/1168113007/
Message was sent while issue was closed.
Yeah, I assumed there was a reason, but that reason might be something like MSVS 6. So, lost to the sands of time. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
