Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Unified Diff: Source/core/frame/FrameView.h

Issue 1165233002: Apply :target styling even if fragment scrolling was skipped. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/FrameView.h
diff --git a/Source/core/frame/FrameView.h b/Source/core/frame/FrameView.h
index bd953b0327053f4d434f1eabc9b14cfa70ccd00c..9646e5cac4e42e5379f375588625d0c68c99c1f7 100644
--- a/Source/core/frame/FrameView.h
+++ b/Source/core/frame/FrameView.h
@@ -239,9 +239,11 @@ public:
void forceLayoutForPagination(const FloatSize& pageSize, const FloatSize& originalPageSize, float maximumShrinkFactor);
- bool scrollToFragment(const KURL&);
- bool scrollToAnchor(const String&);
- void maintainScrollPositionAtAnchor(Node*);
Nate Chapin 2015/06/08 21:54:29 Just to make sure I'm reading this correct: the on
skobes 2015/06/08 22:04:30 Yes... I was making scrollToAnchor(const String&)
+ enum UrlFragmentBehavior {
Nate Chapin 2015/06/08 21:54:29 Would this be more readable as... enum class UrlF
skobes 2015/06/08 22:04:30 Do we want to start using enum class? None of the
Nate Chapin 2015/06/08 22:17:31 I've seen enum classes show up in blink lately and
+ UrlFragmentScroll,
+ UrlFragmentDontScroll
+ };
+ bool processUrlFragment(const KURL&, UrlFragmentBehavior = UrlFragmentScroll);
// Methods to convert points and rects between the coordinate space of the layoutObject, and this view.
IntRect convertFromLayoutObject(const LayoutObject&, const IntRect&) const;
@@ -666,6 +668,8 @@ private:
void updateWidgetsTimerFired(Timer<FrameView>*);
bool updateWidgets();
+ bool processUrlFragmentHelper(const String&, UrlFragmentBehavior);
+ void maintainScrollPositionAtAnchor(Node*);
void scrollToAnchor();
void scrollPositionChanged();
void didScrollTimerFired(Timer<FrameView>*);

Powered by Google App Engine
This is Rietveld 408576698