Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: Source/core/frame/FrameView.h

Issue 1165233002: Apply :target styling even if fragment scrolling was skipped. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 bool invalidateViewportConstrainedObjects(); 232 bool invalidateViewportConstrainedObjects();
233 233
234 void incrementVisuallyNonEmptyCharacterCount(unsigned); 234 void incrementVisuallyNonEmptyCharacterCount(unsigned);
235 void incrementVisuallyNonEmptyPixelCount(const IntSize&); 235 void incrementVisuallyNonEmptyPixelCount(const IntSize&);
236 void setIsVisuallyNonEmpty() { m_isVisuallyNonEmpty = true; } 236 void setIsVisuallyNonEmpty() { m_isVisuallyNonEmpty = true; }
237 void enableAutoSizeMode(const IntSize& minSize, const IntSize& maxSize); 237 void enableAutoSizeMode(const IntSize& minSize, const IntSize& maxSize);
238 void disableAutoSizeMode(); 238 void disableAutoSizeMode();
239 239
240 void forceLayoutForPagination(const FloatSize& pageSize, const FloatSize& or iginalPageSize, float maximumShrinkFactor); 240 void forceLayoutForPagination(const FloatSize& pageSize, const FloatSize& or iginalPageSize, float maximumShrinkFactor);
241 241
242 bool scrollToFragment(const KURL&); 242 enum UrlFragmentBehavior {
Nate Chapin 2015/06/08 21:54:29 Would this be more readable as... enum class UrlF
skobes 2015/06/08 22:04:30 Do we want to start using enum class? None of the
Nate Chapin 2015/06/08 22:17:31 I've seen enum classes show up in blink lately and
243 bool scrollToAnchor(const String&); 243 UrlFragmentScroll,
244 void maintainScrollPositionAtAnchor(Node*); 244 UrlFragmentDontScroll
Nate Chapin 2015/06/08 21:54:29 Just to make sure I'm reading this correct: the on
skobes 2015/06/08 22:04:30 Yes... I was making scrollToAnchor(const String&)
245 };
246 bool processUrlFragment(const KURL&, UrlFragmentBehavior = UrlFragmentScroll );
245 247
246 // Methods to convert points and rects between the coordinate space of the l ayoutObject, and this view. 248 // Methods to convert points and rects between the coordinate space of the l ayoutObject, and this view.
247 IntRect convertFromLayoutObject(const LayoutObject&, const IntRect&) const; 249 IntRect convertFromLayoutObject(const LayoutObject&, const IntRect&) const;
248 IntRect convertToLayoutObject(const LayoutObject&, const IntRect&) const; 250 IntRect convertToLayoutObject(const LayoutObject&, const IntRect&) const;
249 IntPoint convertFromLayoutObject(const LayoutObject&, const IntPoint&) const ; 251 IntPoint convertFromLayoutObject(const LayoutObject&, const IntPoint&) const ;
250 IntPoint convertToLayoutObject(const LayoutObject&, const IntPoint&) const; 252 IntPoint convertToLayoutObject(const LayoutObject&, const IntPoint&) const;
251 253
252 bool isFrameViewScrollCorner(LayoutScrollbarPart* scrollCorner) const { retu rn m_scrollCorner == scrollCorner; } 254 bool isFrameViewScrollCorner(LayoutScrollbarPart* scrollCorner) const { retu rn m_scrollCorner == scrollCorner; }
253 255
254 enum ScrollingReasons { 256 enum ScrollingReasons {
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
659 661
660 bool wasViewportResized(); 662 bool wasViewportResized();
661 void sendResizeEventIfNeeded(); 663 void sendResizeEventIfNeeded();
662 664
663 void updateScrollableAreaSet(); 665 void updateScrollableAreaSet();
664 666
665 void scheduleUpdateWidgetsIfNecessary(); 667 void scheduleUpdateWidgetsIfNecessary();
666 void updateWidgetsTimerFired(Timer<FrameView>*); 668 void updateWidgetsTimerFired(Timer<FrameView>*);
667 bool updateWidgets(); 669 bool updateWidgets();
668 670
671 bool processUrlFragmentHelper(const String&, UrlFragmentBehavior);
672 void maintainScrollPositionAtAnchor(Node*);
669 void scrollToAnchor(); 673 void scrollToAnchor();
670 void scrollPositionChanged(); 674 void scrollPositionChanged();
671 void didScrollTimerFired(Timer<FrameView>*); 675 void didScrollTimerFired(Timer<FrameView>*);
672 676
673 void updateLayersAndCompositingAfterScrollIfNeeded(); 677 void updateLayersAndCompositingAfterScrollIfNeeded();
674 678
675 static bool computeCompositedSelection(LocalFrame&, CompositedSelection&); 679 static bool computeCompositedSelection(LocalFrame&, CompositedSelection&);
676 void updateCompositedSelectionIfNeeded(); 680 void updateCompositedSelectionIfNeeded();
677 681
678 // Returns true if the FrameView's own scrollbars overlay its content when v isible. 682 // Returns true if the FrameView's own scrollbars overlay its content when v isible.
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
878 static const unsigned visualPixelThreshold = 32 * 32; 882 static const unsigned visualPixelThreshold = 32 * 32;
879 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 883 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
880 setIsVisuallyNonEmpty(); 884 setIsVisuallyNonEmpty();
881 } 885 }
882 886
883 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 887 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
884 888
885 } // namespace blink 889 } // namespace blink
886 890
887 #endif // FrameView_h 891 #endif // FrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698