Vertically center stock demo row contents, better up/down arrows

Vertically center stock demo row contents, better up/down arrows

StockRows are now a relatively simple application of flex layout.

The up/down arrows are now rendered within a circle, like
the original version. The arrows are a little bigger,
because.

R=ianh@google.com

Closes #226

Committed: https://chromium.googlesource.com/external/mojo/+/2e6f33b12b5ceec68fffb19ca8c223a880a4729a

[hansmuller, 2015-06-09 22:16:33]

hansmuller@chromium.org changed reviewers:
+ abarth@chromium.org

[hansmuller, 2015-06-09 22:23:38]

Patchset #1 (id:1) has been deleted

[hansmuller, 2015-06-09 22:25:06]

hansmuller@chromium.org changed reviewers:
+ hansmuller@chromium.org

[hansmuller, 2015-06-09 22:25:07]

PTAL

[Hixie, 2015-06-09 22:36:12]

ianh@google.com changed reviewers:
+ ianh@google.com

[Hixie, 2015-06-09 22:36:12]

lgtm

https://codereview.chromium.org/1165223005/diff/20001/sky/examples/stocks2/li...
File sky/examples/stocks2/lib/stock_row.dart (right):

https://codereview.chromium.org/1165223005/diff/20001/sky/examples/stocks2/li...
sky/examples/stocks2/lib/stock_row.dart:34: // TBD: text-align: right
either have TODO(hansmuller) just the commented-out code, I wouldn't say "TBD".

https://codereview.chromium.org/1165223005/diff/20001/sky/examples/stocks2/li...
sky/examples/stocks2/lib/stock_row.dart:42: height: kHeight, //
TODO(hansmuller): This shouldn't be needed
why not?

[hansmuller, 2015-06-09 22:58:28]

https://codereview.chromium.org/1165223005/diff/20001/sky/examples/stocks2/li...
File sky/examples/stocks2/lib/stock_row.dart (right):

https://codereview.chromium.org/1165223005/diff/20001/sky/examples/stocks2/li...
sky/examples/stocks2/lib/stock_row.dart:34: // TBD: text-align: right
On 2015/06/09 22:36:12, Hixie wrote:
> either have TODO(hansmuller) just the commented-out code, I wouldn't say
"TBD".

Done.

https://codereview.chromium.org/1165223005/diff/20001/sky/examples/stocks2/li...
sky/examples/stocks2/lib/stock_row.dart:42: height: kHeight, //
TODO(hansmuller): This shouldn't be needed
On 2015/06/09 22:36:12, Hixie wrote:
> why not?

I think the height of the row should be defined by its contents. If
fonts or icons change (if we were using icons), the layout should still look
essentially the same.

[hansmuller1, 2015-06-09 22:59:35]

Committed patchset #2 (id:40001) manually as
2e6f33b12b5ceec68fffb19ca8c223a880a4729a (presubmit successful).