Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: sky/examples/stocks2/lib/stock_row.dart

Issue 1165223005: Vertically center stock demo row contents, better up/down arrows (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: TBD => TODO Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/examples/stocks2/lib/stock_arrow.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/stocks2/lib/stock_row.dart
diff --git a/sky/examples/stocks2/lib/stock_row.dart b/sky/examples/stocks2/lib/stock_row.dart
index 913ff9cc980efd898c80376636c28e040425efa2..4aea39c11b7b0789ef0c432cb87b3b2f58293dc9 100644
--- a/sky/examples/stocks2/lib/stock_row.dart
+++ b/sky/examples/stocks2/lib/stock_row.dart
@@ -5,13 +5,14 @@
import 'dart:sky' as sky;
import 'package:sky/framework/components2/ink_well.dart';
import 'package:sky/framework/fn2.dart';
+import 'package:sky/framework/rendering/flex.dart';
import 'package:sky/framework/rendering/box.dart';
import 'package:sky/framework/theme/typography.dart' as typography;
import 'stock_arrow.dart';
import 'stock_data.dart';
class StockRow extends Component {
- static const double kHeight = 100.0;
+ static const double kHeight = 70.0;
Stock stock;
@@ -23,36 +24,28 @@ class StockRow extends Component {
String lastSale = "\$${stock.lastSale.toStringAsFixed(2)}";
String changeInPrice = "${stock.percentChange.toStringAsFixed(2)}%";
- if (stock.percentChange > 0)
- changeInPrice = "+" + changeInPrice;
+ if (stock.percentChange > 0) changeInPrice = "+" + changeInPrice;
List<UINode> children = [
- new StockArrow(
- percentChange: stock.percentChange
- ),
- new FlexExpandingChild(new Text(stock.symbol)),
new Container(
- width: 75.0,
- padding: const EdgeDims.only(right: 16.0),
- // text-align: right
- child: new Text(lastSale)
- ),
- // text-align: right, ${typography.black.caption};
- new SizedBox(
- width: 75.0,
- child: new Text(changeInPrice)
- ),
+ child: new StockArrow(percentChange: stock.percentChange),
+ margin: const EdgeDims.only(right: 5.0)),
+ new FlexExpandingChild(new Text(stock.symbol), flex: 2, key: "symbol"),
+ // TODO(hansmuller): text-align: right
+ new FlexExpandingChild(new Text(lastSale), key: "lastSale"),
+ // TODO(hansmuller): text-align: right, ${typography.black.caption};
+ new FlexExpandingChild(new Text(changeInPrice), key: "changeInPrice")
];
return new Container(
padding: const EdgeDims(16.0, 16.0, 20.0, 16.0),
- height: kHeight,
+ height: kHeight, // TODO(hansmuller): This shouldn't be needed
decoration: const BoxDecoration(
- backgroundColor: const sky.Color(0xFFFFFFFF),
- border: const Border(
- bottom: const BorderSide(
- color: const sky.Color(0xFFF4F4F4),
- width: 1.0))),
+ backgroundColor: const sky.Color(0xFFFFFFFF),
+ border: const Border(
+ bottom: const BorderSide(
+ color: const sky.Color(0xFFF4F4F4),
+ width: 1.0))),
child: new FlexContainer(children: children));
}
}
« no previous file with comments | « sky/examples/stocks2/lib/stock_arrow.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698