Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: Source/web/tests/WebPluginContainerTest.cpp

Issue 1165103004: printPage to return void instead of bool (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebaseline fixes Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebPluginContainerImpl.cpp ('k') | public/web/WebPlugin.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebPluginContainerTest.cpp
diff --git a/Source/web/tests/WebPluginContainerTest.cpp b/Source/web/tests/WebPluginContainerTest.cpp
index 1f1acbb7c8913ef825a0b4d169cd43c48fe5e4d6..a9b80beeb8d52710707e3068a2191490296e7915 100644
--- a/Source/web/tests/WebPluginContainerTest.cpp
+++ b/Source/web/tests/WebPluginContainerTest.cpp
@@ -93,8 +93,7 @@ public:
WebString selectionAsMarkup() const override { return WebString("y"); }
bool supportsPaginatedPrint() override { return true; }
int printBegin(const WebPrintParams& printParams) override { return 1; }
- bool printPage(int pageNumber, WebCanvas*) override;
-
+ void printPage(int pageNumber, WebCanvas*, bool unused) override;
private:
TestPluginWebFrameClient* m_testClient;
};
@@ -117,14 +116,12 @@ private:
bool m_printedPage = false;
};
-bool TestPlugin::printPage(int pageNumber, WebCanvas* canvas)
+void TestPlugin::printPage(int pageNumber, WebCanvas* canvas, bool unused)
{
ASSERT(m_testClient);
m_testClient->onPrintPage();
- return true;
}
-
WebPluginContainer* getWebPluginContainer(WebView* webView, const WebString& id)
{
WebElement element = webView->mainFrame()->document().getElementById(id);
« no previous file with comments | « Source/web/WebPluginContainerImpl.cpp ('k') | public/web/WebPlugin.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698