Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: Source/web/WebPluginContainerImpl.cpp

Issue 1165103004: printPage to return void instead of bool (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebaseline fixes Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebPluginContainerImpl.h ('k') | Source/web/tests/WebPluginContainerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebPluginContainerImpl.cpp
diff --git a/Source/web/WebPluginContainerImpl.cpp b/Source/web/WebPluginContainerImpl.cpp
index e5c0cf6b2de18c878c6e93251574c2ba41e8d822..5d8520601b7e7c91e714b6d0e6668d82b125ffb4 100644
--- a/Source/web/WebPluginContainerImpl.cpp
+++ b/Source/web/WebPluginContainerImpl.cpp
@@ -352,16 +352,16 @@ int WebPluginContainerImpl::printBegin(const WebPrintParams& printParams) const
return m_webPlugin->printBegin(printParams);
}
-bool WebPluginContainerImpl::printPage(int pageNumber, GraphicsContext* gc, const IntRect& printRect)
+void WebPluginContainerImpl::printPage(int pageNumber, GraphicsContext* gc, const IntRect& printRect)
{
LayoutObjectDrawingRecorder drawingRecorder(*gc, *m_element->layoutObject(), DisplayItem::Type::WebPlugin, printRect);
if (drawingRecorder.canUseCachedDrawing())
- return true;
+ return;
gc->save();
WebCanvas* canvas = gc->canvas();
- bool ret = m_webPlugin->printPage(pageNumber, canvas);
+ // TODO: Remove third parameter when both blink and chromium changes land for bug496765
+ m_webPlugin->printPage(pageNumber, canvas, false);
gc->restore();
- return ret;
}
void WebPluginContainerImpl::printEnd()
« no previous file with comments | « Source/web/WebPluginContainerImpl.h ('k') | Source/web/tests/WebPluginContainerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698