Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1165003010: Revert r333104: "Added UMA statistics for changing the active window via click or touch events." (Closed)

Created:
5 years, 6 months ago by Jeffrey Yasskin
Modified:
5 years, 6 months ago
Reviewers:
bruthig
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert r333104: "Added UMA statistics for changing the active window via click or touch events." This caused leaks in the ChromeOS valgrind bot: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/37831/steps/memory%20test%3A%20ash_unittests/logs/stdio Leak_DefinitelyLost 712 (136 direct, 576 indirect) bytes in 1 blocks are definitely lost in loss record 3,508 of 4,428 operator new(unsigned long) (m_replacemalloc/vg_replace_malloc.c:1140) ash::(anonymous namespace)::DesktopTaskSwitchMetricRecorderTest::CreateNonPositionableWindow() const (ash/metrics/desktop_task_switch_metric_recorder_unittest.cc:113) ash::(anonymous namespace)::DesktopTaskSwitchMetricRecorderTest_ActivateNonPositionableWindowBetweenTwoPositionableWindowActivations_Test::TestBody() (ash/metrics/desktop_task_switch_metric_recorder_unittest.cc:189) BUG=489813, 489814 TBR=bruthig@chromium.org Committed: https://crrev.com/580afd414f1ba102a53eaa39bc670737efd4b3a6 Cr-Commit-Position: refs/heads/master@{#333185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -506 lines) Patch
M ash/ash.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
D ash/metrics/desktop_task_switch_metric_recorder.h View 1 chunk +0 lines, -39 lines 0 comments Download
D ash/metrics/desktop_task_switch_metric_recorder.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D ash/metrics/desktop_task_switch_metric_recorder_unittest.cc View 1 chunk +0 lines, -338 lines 0 comments Download
M ash/metrics/task_switch_metrics_recorder.h View 2 chunks +0 lines, -8 lines 0 comments Download
M ash/metrics/task_switch_metrics_recorder.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/metrics/task_switch_metrics_recorder_unittest.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M ash/metrics/user_metrics_recorder.h View 4 chunks +0 lines, -15 lines 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 3 chunks +0 lines, -19 lines 0 comments Download
M ash/shell.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165003010/1
5 years, 6 months ago (2015-06-05 23:18:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-06 00:25:30 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-06 00:26:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/580afd414f1ba102a53eaa39bc670737efd4b3a6
Cr-Commit-Position: refs/heads/master@{#333185}

Powered by Google App Engine
This is Rietveld 408576698