Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2117)

Unified Diff: ash/metrics/user_metrics_recorder.cc

Issue 1165003010: Revert r333104: "Added UMA statistics for changing the active window via click or touch events." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/metrics/user_metrics_recorder.h ('k') | ash/shell.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/metrics/user_metrics_recorder.cc
diff --git a/ash/metrics/user_metrics_recorder.cc b/ash/metrics/user_metrics_recorder.cc
index 8229039ea3e29e54e364fd0f4d36a715d7ee82de..cfc4d8ee16d4a79a28fe463ce86ff38e8f60b497 100644
--- a/ash/metrics/user_metrics_recorder.cc
+++ b/ash/metrics/user_metrics_recorder.cc
@@ -4,7 +4,6 @@
#include "ash/metrics/user_metrics_recorder.h"
-#include "ash/metrics/desktop_task_switch_metric_recorder.h"
#include "ash/session/session_state_delegate.h"
#include "ash/shelf/shelf_delegate.h"
#include "ash/shelf/shelf_item_types.h"
@@ -237,11 +236,6 @@ void UserMetricsRecorder::RecordUserMetricsAction(UserMetricsAction action) {
case ash::UMA_CLOSE_THROUGH_CONTEXT_MENU:
base::RecordAction(base::UserMetricsAction("CloseFromContextMenu"));
break;
- case ash::UMA_DESKTOP_SWITCH_TASK:
- base::RecordAction(base::UserMetricsAction("Desktop_SwitchTask"));
- task_switch_metrics_recorder_.OnTaskSwitch(
- TaskSwitchMetricsRecorder::kDesktop);
- break;
case ash::UMA_DRAG_MAXIMIZE_LEFT:
base::RecordAction(base::UserMetricsAction("WindowDrag_MaximizeLeft"));
break;
@@ -604,19 +598,6 @@ void UserMetricsRecorder::RecordUserMetricsAction(UserMetricsAction action) {
}
}
-void UserMetricsRecorder::OnShellInitialized() {
- // Lazy creation of the DesktopTaskSwitchMetricRecorder because it accesses
- // Shell::GetInstance() which is not available when |this| is instantiated.
- if (!desktop_task_switch_metric_recorder_) {
- desktop_task_switch_metric_recorder_.reset(
- new DesktopTaskSwitchMetricRecorder());
- }
-}
-
-void UserMetricsRecorder::OnShellShuttingDown() {
- desktop_task_switch_metric_recorder_.reset();
-}
-
void UserMetricsRecorder::RecordPeriodicMetrics() {
ShelfLayoutManager* manager =
ShelfLayoutManager::ForShelf(Shell::GetPrimaryRootWindow());
« no previous file with comments | « ash/metrics/user_metrics_recorder.h ('k') | ash/shell.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698