Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1164973002: Add mixed samples support to XPs (Closed)

Created:
5 years, 6 months ago by Chris Dalton
Modified:
5 years, 6 months ago
CC:
reviews_skia.org, vbuzinov, Kimmo Kinnunen, nv_mark, reed1
Base URL:
https://skia.googlesource.com/skia.git@upload2_reenablebea
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add mixed samples support to XPs BUG=skia: Committed: https://skia.googlesource.com/skia/+/86ae0a9e465f157eaa263ef7515e10619946ff83

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : All coverage in base class for dst read #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : cleanup #

Patch Set 7 : bool param instead if GrPipelineBuilder #

Total comments: 1

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -82 lines) Patch
M include/gpu/GrXferProcessor.h View 1 2 3 4 5 6 7 7 chunks +20 lines, -6 lines 0 comments Download
M include/gpu/effects/GrCoverageSetOpXP.h View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 1 2 3 4 5 6 4 chunks +8 lines, -15 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrXferProcessor.cpp View 1 2 3 4 5 6 7 5 chunks +25 lines, -9 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 1 2 3 4 5 6 7 1 chunk +9 lines, -0 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 2 3 4 5 6 3 chunks +8 lines, -6 lines 0 comments Download
M src/gpu/effects/GrCustomXfermodePriv.h View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/effects/GrDisableColorXP.h View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 2 3 4 5 6 7 chunks +27 lines, -27 lines 0 comments Download
M src/gpu/gl/GrGLXferProcessor.cpp View 1 2 3 4 5 6 1 chunk +8 lines, -1 line 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 2 3 4 5 6 3 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Chris Dalton
https://codereview.chromium.org/1164973002/diff/20001/include/gpu/GrXferProcessor.h File include/gpu/GrXferProcessor.h (right): https://codereview.chromium.org/1164973002/diff/20001/include/gpu/GrXferProcessor.h#newcode370 include/gpu/GrXferProcessor.h:370: GrXferProcessor* createXferProcessor(const GrPipelineBuilder&, I thought it might be nicer ...
5 years, 6 months ago (2015-06-04 01:19:18 UTC) #2
Mark Kilgard
lgtm
5 years, 6 months ago (2015-06-04 05:08:36 UTC) #4
Chris Dalton
Patchset 3 is maybe a bit more exploratory. It changes GrGLXferProcessor to add the coverage ...
5 years, 6 months ago (2015-06-04 08:22:31 UTC) #5
Chris Dalton
Cleaned it all up. I split this patch into two logical changes. The first one ...
5 years, 6 months ago (2015-06-05 06:36:48 UTC) #6
egdaniel
https://codereview.chromium.org/1164973002/diff/120001/src/gpu/effects/GrCoverageSetOpXP.cpp File src/gpu/effects/GrCoverageSetOpXP.cpp (right): https://codereview.chromium.org/1164973002/diff/120001/src/gpu/effects/GrCoverageSetOpXP.cpp#newcode232 src/gpu/effects/GrCoverageSetOpXP.cpp:232: SkASSERT(!fInvertCoverage || !hasMixedSamples); Lets return NULL here if we ...
5 years, 6 months ago (2015-06-08 21:29:46 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164973002/140001
5 years, 6 months ago (2015-06-08 21:33:47 UTC) #10
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 6 months ago (2015-06-08 21:33:48 UTC) #11
egdaniel
lgtm
5 years, 6 months ago (2015-06-08 21:34:12 UTC) #12
Chris Dalton
5 years, 6 months ago (2015-06-08 21:38:53 UTC) #13
reed1
api lgtm
5 years, 6 months ago (2015-06-08 21:40:48 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-08 21:46:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164973002/140001
5 years, 6 months ago (2015-06-08 22:10:08 UTC) #19
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 22:11:09 UTC) #20
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/86ae0a9e465f157eaa263ef7515e10619946ff83

Powered by Google App Engine
This is Rietveld 408576698