Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: vm/symbols.h

Issue 11648006: Create read only handles for empty_array and sentinel objects (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/stub_code_x64_test.cc ('k') | vm/symbols.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/symbols.h
===================================================================
--- vm/symbols.h (revision 16415)
+++ vm/symbols.h (working copy)
@@ -224,8 +224,6 @@
return reinterpret_cast<RawString**>(&predefined_);
}
- static bool IsPredefinedHandle(uword address);
-
static void DumpStats();
private:
@@ -278,27 +276,6 @@
static intptr_t num_of_grows_;
static intptr_t collision_count_[kMaxCollisionBuckets];
- // Structure for managing handles allocation for symbols that are
- // stored in the vm isolate. We don't want these handles to be
- // destroyed as part of the C++ static destructors and hence this
- // object is dynamically allocated.
- class ReadOnlyHandles {
- public:
- ReadOnlyHandles() { }
- uword AllocateHandle() {
- return handles_.AllocateScopedHandle();
- }
- bool IsValidHandle(uword address) {
- return handles_.IsValidScopedHandle(address);
- }
-
- private:
- VMHandles handles_;
-
- DISALLOW_COPY_AND_ASSIGN(ReadOnlyHandles);
- };
- static ReadOnlyHandles* predefined_handles_;
-
#define DECLARE_SYMBOL_HANDLE(symbol) \
static String* symbol##_handle_;
PREDEFINED_SYMBOL_HANDLES_LIST(DECLARE_SYMBOL_HANDLE)
« no previous file with comments | « vm/stub_code_x64_test.cc ('k') | vm/symbols.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698