Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: vm/symbols.cc

Issue 11648006: Create read only handles for empty_array and sentinel objects (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/symbols.h ('k') | vm/unit_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/symbols.cc
===================================================================
--- vm/symbols.cc (revision 16415)
+++ vm/symbols.cc (working copy)
@@ -18,8 +18,6 @@
RawString* Symbols::predefined_[Symbols::kMaxId];
-Symbols::ReadOnlyHandles* Symbols::predefined_handles_ = NULL;
-
#define DEFINE_SYMBOL_HANDLE(symbol) \
String* Symbols::symbol##_handle_ = NULL;
PREDEFINED_SYMBOL_HANDLES_LIST(DEFINE_SYMBOL_HANDLE)
@@ -81,10 +79,9 @@
predefined_[kMaxPredefinedId + c] = FromUTF32(&c, 1);
}
- predefined_handles_ = new ReadOnlyHandles();
#define INITIALIZE_SYMBOL_HANDLE(symbol) \
symbol##_handle_ = reinterpret_cast<String*>( \
- predefined_handles_->AllocateHandle()); \
+ Dart::AllocateReadOnlyHandle()); \
*symbol##_handle_ = symbol();
PREDEFINED_SYMBOL_HANDLES_LIST(INITIALIZE_SYMBOL_HANDLE)
#undef INITIALIZE_SYMBOL_HANDLE
@@ -277,11 +274,6 @@
}
-bool Symbols::IsPredefinedHandle(uword address) {
- return predefined_handles_->IsValidHandle(address);
-}
-
-
void Symbols::DumpStats() {
if (FLAG_dump_symbol_stats) {
intptr_t table_size = 0;
« no previous file with comments | « vm/symbols.h ('k') | vm/unit_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698