Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Unified Diff: Source/core/workers/WorkerObjectProxy.h

Issue 1164753004: Tidy up CompositorWorkerManager unit tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: compile fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/workers/WorkerObjectProxy.h
diff --git a/Source/core/workers/WorkerObjectProxy.h b/Source/core/workers/WorkerObjectProxy.h
index 7703b8013291572c0514b89a66e90ca181b2afd0..579ead70be45cb443b39839132e20402738f95e6 100644
--- a/Source/core/workers/WorkerObjectProxy.h
+++ b/Source/core/workers/WorkerObjectProxy.h
@@ -50,7 +50,7 @@ class WorkerMessagingProxy;
// WorkerMessagingProxy on the worker object thread.
//
// Used only by Dedicated Worker.
kinuko 2015/06/08 04:36:58 Looks like this comment is stale, could we update?
sof 2015/06/08 08:18:16 Certainly, done.
-class CORE_EXPORT WorkerObjectProxy final : public WorkerReportingProxy {
+class CORE_EXPORT WorkerObjectProxy : public WorkerReportingProxy {
public:
static PassOwnPtr<WorkerObjectProxy> create(ExecutionContext*, WorkerMessagingProxy*);
kinuko 2015/06/08 04:36:59 Could we have ASSERT(!messagingProxy) in .cc so th
sof 2015/06/08 08:18:16 That's well worth it, now done.
virtual ~WorkerObjectProxy() { }
@@ -71,9 +71,10 @@ public:
virtual void workerThreadTerminated() override;
virtual void willDestroyWorkerGlobalScope() override { }
-private:
+protected:
WorkerObjectProxy(ExecutionContext*, WorkerMessagingProxy*);
+private:
// These objects always outlive this proxy.
ExecutionContext* m_executionContext;
WorkerMessagingProxy* m_messagingProxy;

Powered by Google App Engine
This is Rietveld 408576698