Tidy up CompositorWorkerManager unit tests.

Source/core/workers/WorkerObjectProxy.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 31 matching lines @@
 class ConsoleMessage;
 class ExecutionContext;
 class ExecutionContextTask;
 class WorkerMessagingProxy;
 
 // A proxy to talk to the worker object. This object is created on the
 // worker object thread (i.e. usually the main thread), passed on to
 // the worker thread, and used just to proxy messages to the
 // WorkerMessagingProxy on the worker object thread.
 //
 // Used only by Dedicated Worker.

[kinuko, 2015/06/08 04:36:58]

Looks like this comment is stale, could we update?  (Now could be used by
in-process workers like DedicatedWorker and CompositorWorker)

[sof, 2015/06/08 08:18:16]

Certainly, done.

-class CORE_EXPORT WorkerObjectProxy final : public WorkerReportingProxy {
+class CORE_EXPORT WorkerObjectProxy : public WorkerReportingProxy {
 public:
     static PassOwnPtr<WorkerObjectProxy> create(ExecutionContext*, WorkerMessagingProxy*);

[kinuko, 2015/06/08 04:36:59]

Could we have ASSERT(!messagingProxy) in .cc so that instantiating this using
public method wouldn't end up with null messaging proxy?

[sof, 2015/06/08 08:18:16]

That's well worth it, now done.

     virtual ~WorkerObjectProxy() { }
 
     void postMessageToWorkerObject(PassRefPtr<SerializedScriptValue>, PassOwnPtr<MessagePortChannelArray>);
     void postTaskToMainExecutionContext(PassOwnPtr<ExecutionContextTask>);
     void confirmMessageFromWorkerObject(bool hasPendingActivity);
     void reportPendingActivity(bool hasPendingActivity);
 
     // WorkerReportingProxy overrides.
     virtual void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, int exceptionId) override;
     virtual void reportConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) override;
     virtual void postMessageToPageInspector(const String&) override;
     virtual void postWorkerConsoleAgentEnabled() override;
     virtual void didEvaluateWorkerScript(bool success) override { };
     virtual void workerGlobalScopeStarted(WorkerGlobalScope*) override { }
     virtual void workerGlobalScopeClosed() override;
     virtual void workerThreadTerminated() override;
     virtual void willDestroyWorkerGlobalScope() override { }
 
-private:
+protected:
     WorkerObjectProxy(ExecutionContext*, WorkerMessagingProxy*);
 
+private:
     // These objects always outlive this proxy.
     ExecutionContext* m_executionContext;
     WorkerMessagingProxy* m_messagingProxy;
 };
 
 } // namespace blink
 
 #endif // WorkerObjectProxy_h