Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: net/base/network_quality.h

Issue 1164713004: Store network quality samples so we can compute percentiles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/network_quality.h
diff --git a/net/base/network_quality.h b/net/base/network_quality.h
index 4e2985776e0f4a8430b80c7523751391b4b0c0b7..5d54d8c5c7a0f4be5394153f5203c2c11741f055 100644
--- a/net/base/network_quality.h
+++ b/net/base/network_quality.h
@@ -8,42 +8,35 @@
#include <stdint.h>
#include "base/time/time.h"
+#include "net/base/net_export.h"
namespace net {
-// API that is used to report the current network quality as estimated by the
-// NetworkQualityEstimator.
-struct NET_EXPORT_PRIVATE NetworkQuality {
- NetworkQuality(const base::TimeDelta& fastest_rtt,
- double fastest_rtt_confidence,
- uint64_t peak_throughput_kbps,
- double peak_throughput_kbps_confidence)
- : fastest_rtt(fastest_rtt),
- fastest_rtt_confidence(fastest_rtt_confidence),
- peak_throughput_kbps(peak_throughput_kbps),
- peak_throughput_kbps_confidence(peak_throughput_kbps_confidence) {}
-
- ~NetworkQuality() {}
-
- // The fastest round trip time observed for the current connection.
- const base::TimeDelta fastest_rtt;
-
- // Confidence of the |fastest_rtt| estimate. Value lies between 0.0 and 1.0
- // with 0.0 being no confidence and 1.0 implying that estimates are same as
- // ground truth.
- // TODO(tbansal): Define units so values intermediate between 0.0 and 1.0 are
- // meaningful.
- const double fastest_rtt_confidence;
-
- // Peak throughput in Kbps observed for the current connection.
- const uint64_t peak_throughput_kbps;
-
- // Confidence of the |peak_throughput_kbps| estimate. Value lies between 0.0
- // and 1.0 with 0.0 being no confidence and 1.0 implying that estimates are
- // same as ground truth.
- // TODO(tbansal): Define units so values intermediate between 0.0 and 1.0 are
- // meaningful.
- const double peak_throughput_kbps_confidence;
+// API that is used to report the network quality of a network connection as
+// estimated by the NetworkQualityEstimator.
+class NET_EXPORT_PRIVATE NetworkQuality {
+ public:
+ // |rtt| is the estimate of the round trip time.
+ // |downstream_throughput_kbps| is the estimate of the downstream throughput.
+ NetworkQuality(const base::TimeDelta& rtt,
+ int32_t downstream_throughput_kbps);
+
+ ~NetworkQuality();
+
+ // Returns the estimate of the round trip time.
+ const base::TimeDelta& rtt() const { return rtt_; }
+
+ // Returns the estimate of the downstream throughput in Kbps.
bengr 2015/06/11 00:14:56 Is this bytes or bits? Maybe KB/s?
tbansal1 2015/06/11 01:43:00 Kilo bits per second. Added comment to make it una
+ int32_t downstream_throughput_kbps() const {
+ return downstream_throughput_kbps_;
+ }
+
+ private:
+ // Estimated round trip time.
+ const base::TimeDelta rtt_;
+
+ // Estimated downstream throughput in Kbps.
+ const int32_t downstream_throughput_kbps_;
};
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698