components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc - Issue 1164713004: Store network quality samples so we can compute percentiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

Issue 1164713004: Store network quality samples so we can compute percentiles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

index 6beee3cf6ce6f509c9b0ebae0bf41df0b7958cbc..667c86df30242e0699e843511c0ef0ffbbc4e219 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

@@ -377,7 +377,7 @@ bool DataReductionProxyConfig::IsNetworkQualityProhibitivelySlow(

return false;

net::NetworkQuality network_quality =

- network_quality_estimator->GetEstimate();

+ network_quality_estimator->GetPeakEstimate();

// TODO(tbansal): Set |network_prohibitively_slow| based on medians

// provided by NetworkQualityEstimator API and field trial parameters.

// Also, ensure that state of network is not changed more than once within

« no previous file with comments | « no previous file | net/base/network_quality.h » ('j') | net/base/network_quality.h » ('J')