Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 1164613002: DevTools: Simplify firstFrameAfterCommit. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressing comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/components_lazy/FilmStripModel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js b/Source/devtools/front_end/timeline/TimelinePanel.js
index d2440e54e882913a88107a366ffefce8e2b7c4b0..0465f834943cbd37941195edaaf77aaa7334621d 100644
--- a/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -1047,7 +1047,9 @@ WebInspector.TimelinePanel.prototype = {
var frame = /** @type {!WebInspector.TimelineFrame} */ (this._selection.object());
if (Runtime.experiments.isEnabled("filmStripInNetworkAndTimeline") && !this._filmStripModel)
this._filmStripModel = new WebInspector.FilmStripModel(this._tracingModel);
- var filmStripFrame = this._filmStripModel && this._filmStripModel.firstFrameAfterCommit(frame.endTime);
+ var filmStripFrame = this._filmStripModel && this._filmStripModel.frameByTimestamp(frame.endTime);
+ if (filmStripFrame && filmStripFrame.timestamp - frame.endTime > 10)
+ filmStripFrame = null;
this.showInDetails(WebInspector.TimelineUIUtils.generateDetailsContentForFrame(this._lazyFrameModel, frame, filmStripFrame));
if (frame.layerTree) {
var layersView = this._layersView();
« no previous file with comments | « Source/devtools/front_end/components_lazy/FilmStripModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698