Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: Source/devtools/front_end/components_lazy/FilmStripModel.js

Issue 1164613002: DevTools: Simplify firstFrameAfterCommit. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressing comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/components_lazy/FilmStripModel.js
diff --git a/Source/devtools/front_end/components_lazy/FilmStripModel.js b/Source/devtools/front_end/components_lazy/FilmStripModel.js
index 55d25b7e44f6f343aec957bd3f37d67e33488130..9dd1f8fd879807862f4dbf286119dde9f6063303 100644
--- a/Source/devtools/front_end/components_lazy/FilmStripModel.js
+++ b/Source/devtools/front_end/components_lazy/FilmStripModel.js
@@ -54,20 +54,19 @@ WebInspector.FilmStripModel.prototype = {
* @param {number} timestamp
* @return {?WebInspector.FilmStripModel.Frame}
*/
- firstFrameAfterCommit: function(timestamp)
+ frameByTimestamp: function(timestamp)
{
- var bestIndex = 0;
- var bestDelta = Number.MAX_VALUE;
- for (var i = 0; i < this._frames.length; ++i) {
- var delta = this._frames[i].timestamp - timestamp;
- if (delta < 0)
- continue;
- if (delta < bestDelta) {
- bestIndex = i;
- bestDelta = delta;
- }
+ /**
+ * @param {number} timestamp
+ * @param {!WebInspector.FilmStripModel.Frame} frame
+ * @return {number}
+ */
+ function comparator(timestamp, frame)
+ {
+ return timestamp - frame.timestamp;
}
- return bestDelta < 10 ? this._frames[bestIndex] : null;
+ var index = this._frames.lowerBound(timestamp, comparator);
+ return index < this._frames.length ? this._frames[index] : null;
}
}
« no previous file with comments | « no previous file | Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698