Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: Source/core/css/CSSReflectValue.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSProperty.cpp ('k') | Source/core/css/CSSReflectValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSReflectValue.h
diff --git a/Source/core/css/CSSReflectValue.h b/Source/core/css/CSSReflectValue.h
index 18569543adc4084aa81e53a4dbac803c347fd59a..26c088c93a872c114829fc968912fc1672e4fcfc 100644
--- a/Source/core/css/CSSReflectValue.h
+++ b/Source/core/css/CSSReflectValue.h
@@ -34,17 +34,17 @@ namespace blink {
class CSSPrimitiveValue;
-class CSSReflectValue : public CSSValue {
+class CSSReflectValue : public CSSValueObject {
public:
static PassRefPtrWillBeRawPtr<CSSReflectValue> create(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> direction,
- PassRefPtrWillBeRawPtr<CSSPrimitiveValue> offset, PassRefPtrWillBeRawPtr<CSSValue> mask)
+ PassRefPtrWillBeRawPtr<CSSPrimitiveValue> offset, NullableCSSValue mask)
{
return adoptRefWillBeNoop(new CSSReflectValue(direction, offset, mask));
}
CSSPrimitiveValue* direction() const { return m_direction.get(); }
CSSPrimitiveValue* offset() const { return m_offset.get(); }
- CSSValue* mask() const { return m_mask.get(); }
+ NullableCSSValue mask() const { return m_mask; }
String customCSSText() const;
@@ -53,8 +53,8 @@ public:
DECLARE_TRACE_AFTER_DISPATCH();
private:
- CSSReflectValue(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> direction, PassRefPtrWillBeRawPtr<CSSPrimitiveValue> offset, PassRefPtrWillBeRawPtr<CSSValue> mask)
- : CSSValue(ReflectClass)
+ CSSReflectValue(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> direction, PassRefPtrWillBeRawPtr<CSSPrimitiveValue> offset, NullableCSSValue mask)
+ : CSSValueObject(ReflectClass)
, m_direction(direction)
, m_offset(offset)
, m_mask(mask)
@@ -63,7 +63,7 @@ private:
RefPtrWillBeMember<CSSPrimitiveValue> m_direction;
RefPtrWillBeMember<CSSPrimitiveValue> m_offset;
- RefPtrWillBeMember<CSSValue> m_mask;
+ NullableCSSValue m_mask;
};
DEFINE_CSS_VALUE_TYPE_CASTS(CSSReflectValue, isReflectValue());
« no previous file with comments | « Source/core/css/CSSProperty.cpp ('k') | Source/core/css/CSSReflectValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698