Source/core/css/CSSReflectValue.cpp - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSReflectValue.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSReflectValue.cpp

diff --git a/Source/core/css/CSSReflectValue.cpp b/Source/core/css/CSSReflectValue.cpp

index 85847a1e64dae11f66baec7122606d3058122c64..8850e9e002b9d27958cbb9bada6d5fd75ef305fb 100644

--- a/Source/core/css/CSSReflectValue.cpp

+++ b/Source/core/css/CSSReflectValue.cpp

@@ -41,7 +41,7 @@ bool CSSReflectValue::equals(const CSSReflectValue& other) const

{

return m_direction == other.m_direction

&& compareCSSValuePtr(m_offset, other.m_offset)

- && compareCSSValuePtr(m_mask, other.m_mask);

+ && m_mask == other.m_mask;

}

DEFINE_TRACE_AFTER_DISPATCH(CSSReflectValue)

@@ -49,7 +49,7 @@ DEFINE_TRACE_AFTER_DISPATCH(CSSReflectValue)

visitor->trace(m_direction);

visitor->trace(m_offset);

visitor->trace(m_mask);

- CSSValue::traceAfterDispatch(visitor);

+ CSSValueObject::traceAfterDispatch(visitor);

}

} // namespace blink

« no previous file with comments | « Source/core/css/CSSReflectValue.h ('k') | Source/core/css/CSSSVGDocumentValue.h » ('j') | no next file with comments »