Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: Source/core/animation/css/CSSAnimations.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/css/CSSAnimatableValueFactory.cpp ('k') | Source/core/core.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/css/CSSAnimations.cpp
diff --git a/Source/core/animation/css/CSSAnimations.cpp b/Source/core/animation/css/CSSAnimations.cpp
index bc59b4374015752c704beb104242b344db6afbb2..26066096be89917cd4fd9f7f311ab91c4f19f5cd 100644
--- a/Source/core/animation/css/CSSAnimations.cpp
+++ b/Source/core/animation/css/CSSAnimations.cpp
@@ -89,14 +89,14 @@ static PassRefPtrWillBeRawPtr<StringKeyframeEffectModel> createKeyframeEffectMod
CSSPropertyID property = properties.propertyAt(j).id();
specifiedPropertiesForUseCounter.add(property);
if (property == CSSPropertyAnimationTimingFunction) {
- CSSValue* value = properties.propertyAt(j).value();
+ CSSValue value = properties.propertyAt(j).value();
RefPtr<TimingFunction> timingFunction;
- if (value->isInheritedValue() && parentStyle->animations()) {
+ if (value.isInheritedValue() && parentStyle->animations()) {
timingFunction = parentStyle->animations()->timingFunctionList()[0];
- } else if (value->isValueList()) {
- timingFunction = CSSToStyleMap::mapAnimationTimingFunction(toCSSValueList(value)->item(0));
+ } else if (value.isValueList()) {
+ timingFunction = CSSToStyleMap::mapAnimationTimingFunction(toCSSValueList(value).item(0));
} else {
- ASSERT(value->isCSSWideKeyword());
+ ASSERT(value.isCSSWideKeyword());
timingFunction = CSSTimingData::initialTimingFunction();
}
keyframe->setEasing(timingFunction.release());
« no previous file with comments | « Source/core/animation/css/CSSAnimatableValueFactory.cpp ('k') | Source/core/core.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698