Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/css/CSSAnimatableValueFactory.cpp
diff --git a/Source/core/animation/css/CSSAnimatableValueFactory.cpp b/Source/core/animation/css/CSSAnimatableValueFactory.cpp
index ae7c1ff97b7d370ed4ec7444ba718d48590ee98b..52deca413d367a00a507c3e6af5b04032d881cc0 100644
--- a/Source/core/animation/css/CSSAnimatableValueFactory.cpp
+++ b/Source/core/animation/css/CSSAnimatableValueFactory.cpp
@@ -179,8 +179,8 @@ inline static PassRefPtrWillBeRawPtr<AnimatableValue> createFromLengthSize(const
inline static PassRefPtrWillBeRawPtr<AnimatableValue> createFromStyleImage(StyleImage* image)
{
if (image) {
- if (RefPtrWillBeRawPtr<CSSValue> cssValue = image->cssValue())
- return AnimatableImage::create(cssValue.release());
+ if (NullableCSSValue cssValue = image->cssValue())
+ return AnimatableImage::create(*cssValue);
}
return AnimatableUnknown::create(CSSValueNone);
}
« no previous file with comments | « Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp ('k') | Source/core/animation/css/CSSAnimations.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698