Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp
diff --git a/Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp b/Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp
index fd0975b40a8d00feb8b093c36f9843af1a441a0b..c0157a76ec7deef06ba04e0cbde6e10ce1463651 100644
--- a/Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp
+++ b/Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp
@@ -43,11 +43,11 @@ TEST_F(AnimationSVGStrokeDasharrayStyleInterpolationTest, Zero)
start->append(CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_EMS));
start->append(CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_PX));
- RefPtrWillBeRawPtr<CSSValueList> value = roundTrip(*start);
+ RefPtrWillBeRawPtr<CSSValueList> value = roundTrip(start);
EXPECT_EQ(value->length(), 3u);
- testPrimitiveValue(*value->item(0), 0, CSSPrimitiveValue::CSS_PERCENTAGE);
- testPrimitiveValue(*value->item(1), 0, CSSPrimitiveValue::CSS_EMS);
- testPrimitiveValue(*value->item(2), 0, CSSPrimitiveValue::CSS_PX);
+ testPrimitiveValue(value->item(0), 0, CSSPrimitiveValue::CSS_PERCENTAGE);
+ testPrimitiveValue(value->item(1), 0, CSSPrimitiveValue::CSS_EMS);
+ testPrimitiveValue(value->item(2), 0, CSSPrimitiveValue::CSS_PX);
}
TEST_F(AnimationSVGStrokeDasharrayStyleInterpolationTest, SingleUnit)
@@ -59,22 +59,22 @@ TEST_F(AnimationSVGStrokeDasharrayStyleInterpolationTest, SingleUnit)
start->append(CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_PERCENTAGE));
start->append(CSSPrimitiveValue::create(30, CSSPrimitiveValue::CSS_EMS));
- RefPtrWillBeRawPtr<CSSValueList> value = roundTrip(*start);
+ RefPtrWillBeRawPtr<CSSValueList> value = roundTrip(start);
EXPECT_EQ(value->length(), 5u);
- testPrimitiveValue(*value->item(0), 0, CSSPrimitiveValue::CSS_PX);
- testPrimitiveValue(*value->item(1), 10, CSSPrimitiveValue::CSS_EMS);
- testPrimitiveValue(*value->item(2), 0, CSSPrimitiveValue::CSS_EMS);
- testPrimitiveValue(*value->item(3), 0, CSSPrimitiveValue::CSS_PERCENTAGE);
- testPrimitiveValue(*value->item(4), 30, CSSPrimitiveValue::CSS_EMS);
+ testPrimitiveValue(value->item(0), 0, CSSPrimitiveValue::CSS_PX);
+ testPrimitiveValue(value->item(1), 10, CSSPrimitiveValue::CSS_EMS);
+ testPrimitiveValue(value->item(2), 0, CSSPrimitiveValue::CSS_EMS);
+ testPrimitiveValue(value->item(3), 0, CSSPrimitiveValue::CSS_PERCENTAGE);
+ testPrimitiveValue(value->item(4), 30, CSSPrimitiveValue::CSS_EMS);
}
TEST_F(AnimationSVGStrokeDasharrayStyleInterpolationTest, None)
{
RefPtrWillBeRawPtr<CSSPrimitiveValue> start = CSSPrimitiveValue::createIdentifier(CSSValueNone);
- RefPtrWillBeRawPtr<CSSValueList> value = roundTrip(*start);
+ RefPtrWillBeRawPtr<CSSValueList> value = roundTrip(start);
EXPECT_EQ(value->length(), 1u);
- testPrimitiveValue(*value->item(0), 0, CSSPrimitiveValue::CSS_PX);
+ testPrimitiveValue(value->item(0), 0, CSSPrimitiveValue::CSS_PX);
}
}
« no previous file with comments | « Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp ('k') | Source/core/animation/ShadowStyleInterpolation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698