Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp
diff --git a/Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp b/Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp
index 716a643a9a16385711e0ef9dcee351683be5d1b0..d2f2867c9558599906222d12b6e4bfab2367f44c 100644
--- a/Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp
+++ b/Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp
@@ -42,7 +42,7 @@ bool SVGStrokeDasharrayStyleInterpolation::canCreateFrom(const CSSValue& value)
const CSSValueList& valueList = toCSSValueList(value);
for (size_t index = 0; index < valueList.length(); ++index) {
- if (!LengthStyleInterpolation::canCreateFrom(*valueList.item(index)))
+ if (!LengthStyleInterpolation::canCreateFrom(valueList.item(index)))
return false;
}
return true;
@@ -65,8 +65,8 @@ PassRefPtrWillBeRawPtr<SVGStrokeDasharrayStyleInterpolation> SVGStrokeDasharrayS
OwnPtrWillBeRawPtr<InterpolableList> interpolableEnd = InterpolableList::create(size);
for (size_t i = 0; i < size; ++i) {
- const CSSPrimitiveValue& from = *toCSSPrimitiveValue(valueListStart.item(i % valueListStart.length()));
- const CSSPrimitiveValue& to = *toCSSPrimitiveValue(valueListEnd.item(i % valueListEnd.length()));
+ const CSSValue from = valueListStart.item(i % valueListStart.length());
+ const CSSValue to = valueListEnd.item(i % valueListEnd.length());
interpolableStart->set(i, LengthStyleInterpolation::toInterpolableValue(from));
interpolableEnd->set(i, LengthStyleInterpolation::toInterpolableValue(to));
@@ -76,7 +76,7 @@ PassRefPtrWillBeRawPtr<SVGStrokeDasharrayStyleInterpolation> SVGStrokeDasharrayS
void SVGStrokeDasharrayStyleInterpolation::apply(StyleResolverState& state) const
{
- StyleBuilder::applyProperty(m_id, state, interpolableValueToStrokeDasharray(*m_cachedValue).get());
+ StyleBuilder::applyProperty(m_id, state, interpolableValueToStrokeDasharray(*m_cachedValue));
}
}

Powered by Google App Engine
This is Rietveld 408576698