Source/core/css/CSSImageGeneratorValue.h - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSImageGeneratorValue.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Some small fixes to (hopefully) fix some broken tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSImageGeneratorValue.h

diff --git a/Source/core/css/CSSImageGeneratorValue.h b/Source/core/css/CSSImageGeneratorValue.h

index b209186ea08ec3e03e2ace5f77d4de70881ba2bb..2b78ba8ad7d37000066cb714323a559d454faa65 100644

--- a/Source/core/css/CSSImageGeneratorValue.h

+++ b/Source/core/css/CSSImageGeneratorValue.h

@@ -50,7 +50,7 @@ struct SizeAndCount {

typedef HashMap<const LayoutObject*, SizeAndCount> LayoutObjectSizeCountMap;

-class CSSImageGeneratorValue : public CSSValue {

+class CSSImageGeneratorValue : public CSSValueObject {

public:

~CSSImageGeneratorValue();

@@ -66,7 +66,7 @@ public:

void loadSubimages(Document*);

- DEFINE_INLINE_TRACE_AFTER_DISPATCH() { CSSValue::traceAfterDispatch(visitor); }

+ DEFINE_INLINE_TRACE_AFTER_DISPATCH() { CSSValueObject::traceAfterDispatch(visitor); }

protected:

explicit CSSImageGeneratorValue(ClassType);

« Source/core/css/CSSBasicShapes.cpp ('K') | « Source/core/css/CSSGridTemplateAreasValue.cpp ('k') | Source/core/css/CSSImageGeneratorValue.cpp » ('j') | Source/core/css/CSSValue.h » ('J')