Source/core/css/CSSFontFeatureValue.h - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSFontFeatureValue.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Some small fixes to (hopefully) fix some broken tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSFontFeatureValue.h

diff --git a/Source/core/css/CSSFontFeatureValue.h b/Source/core/css/CSSFontFeatureValue.h

index 719cab61ab4aea789b5ac7e30eb7e28cb3667d11..9f72d23b46d3b1fb345c116b2d4cd66b741c4379 100644

--- a/Source/core/css/CSSFontFeatureValue.h

+++ b/Source/core/css/CSSFontFeatureValue.h

@@ -31,7 +31,7 @@

namespace blink {

-class CSSFontFeatureValue : public CSSValue {

+class CSSFontFeatureValue : public CSSValueObject {

public:

static PassRefPtrWillBeRawPtr<CSSFontFeatureValue> create(const AtomicString& tag, int value)

{

@@ -44,7 +44,7 @@ public:

bool equals(const CSSFontFeatureValue&) const;

- DEFINE_INLINE_TRACE_AFTER_DISPATCH() { CSSValue::traceAfterDispatch(visitor); }

+ DEFINE_INLINE_TRACE_AFTER_DISPATCH() { CSSValueObject::traceAfterDispatch(visitor); }

private:

CSSFontFeatureValue(const AtomicString& tag, int value);

« Source/core/css/CSSBasicShapes.cpp ('K') | « Source/core/css/CSSFontFaceSrcValue.h ('k') | Source/core/css/CSSFontFeatureValue.cpp » ('j') | Source/core/css/CSSValue.h » ('J')