Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: Source/core/css/CSSCrossfadeValue.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Some small fixes to (hopefully) fix some broken tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSCrossfadeValue.h
diff --git a/Source/core/css/CSSCrossfadeValue.h b/Source/core/css/CSSCrossfadeValue.h
index 529e9689863eb8657acc216e5fa51f185b274557..070f8956790e474e3c9822ec47d07a11ebc9ea62 100644
--- a/Source/core/css/CSSCrossfadeValue.h
+++ b/Source/core/css/CSSCrossfadeValue.h
@@ -42,7 +42,7 @@ class LayoutObject;
class CSSCrossfadeValue final : public CSSImageGeneratorValue {
friend class CrossfadeSubimageObserverProxy;
public:
- static PassRefPtrWillBeRawPtr<CSSCrossfadeValue> create(PassRefPtrWillBeRawPtr<CSSValue> fromValue, PassRefPtrWillBeRawPtr<CSSValue> toValue)
+ static PassRefPtrWillBeRawPtr<CSSCrossfadeValue> create(CSSValue fromValue, CSSValue toValue)
{
return adoptRefWillBeNoop(new CSSCrossfadeValue(fromValue, toValue));
}
@@ -69,7 +69,7 @@ public:
DECLARE_TRACE_AFTER_DISPATCH();
private:
- CSSCrossfadeValue(PassRefPtrWillBeRawPtr<CSSValue> fromValue, PassRefPtrWillBeRawPtr<CSSValue> toValue)
+ CSSCrossfadeValue(CSSValue fromValue, CSSValue toValue)
: CSSImageGeneratorValue(CrossfadeClass)
, m_fromValue(fromValue)
, m_toValue(toValue)
@@ -93,8 +93,8 @@ private:
void crossfadeChanged(const IntRect&);
- RefPtrWillBeMember<CSSValue> m_fromValue;
- RefPtrWillBeMember<CSSValue> m_toValue;
+ CSSValue m_fromValue;
+ CSSValue m_toValue;
RefPtrWillBeMember<CSSPrimitiveValue> m_percentageValue;
ResourcePtr<ImageResource> m_cachedFromImage;

Powered by Google App Engine
This is Rietveld 408576698