Source/core/css/CSSComputedStyleDeclaration.h - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSComputedStyleDeclaration.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Some small fixes to (hopefully) fix some broken tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/CSSBasicShapes.cpp ('K') | « Source/core/css/CSSCalculationValueTest.cpp ('k') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | Source/core/css/CSSValue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSComputedStyleDeclaration.h

diff --git a/Source/core/css/CSSComputedStyleDeclaration.h b/Source/core/css/CSSComputedStyleDeclaration.h

index c7bb727c3c1552e15591f894d4bf1df6ad5ff4d0..9a13fbe70350e16adc81ef611f00f7a1af4609bc 100644

--- a/Source/core/css/CSSComputedStyleDeclaration.h

+++ b/Source/core/css/CSSComputedStyleDeclaration.h

@@ -62,8 +62,8 @@ public:

virtual PassRefPtrWillBeRawPtr<MutableStylePropertySet> copyProperties() const override;

- PassRefPtrWillBeRawPtr<CSSValue> getPropertyCSSValue(CSSPropertyID) const;

- PassRefPtrWillBeRawPtr<CSSValue> getFontSizeCSSValuePreferringKeyword() const;

+ NullableCSSValue getPropertyCSSValue(CSSPropertyID) const;

+ NullableCSSValue getFontSizeCSSValuePreferringKeyword() const;

bool isMonospaceFont() const;

PassRefPtrWillBeRawPtr<MutableStylePropertySet> copyPropertiesInSet(const Vector<CSSPropertyID>&) const;

@@ -93,11 +93,11 @@ private:

virtual String removeProperty(const String& propertyName, ExceptionState&) override;

virtual String cssText() const override;

virtual void setCSSText(const String&, ExceptionState&) override;

- virtual PassRefPtrWillBeRawPtr<CSSValue> getPropertyCSSValueInternal(CSSPropertyID) override;

+ virtual NullableCSSValue getPropertyCSSValueInternal(CSSPropertyID) override;

virtual String getPropertyValueInternal(CSSPropertyID) override;

virtual void setPropertyInternal(CSSPropertyID, const String& value, bool important, ExceptionState&) override;

- virtual bool cssPropertyMatches(CSSPropertyID, const CSSValue*) const override;

+ virtual bool cssPropertyMatches(CSSPropertyID, const CSSValue) const override;

RefPtrWillBeMember<Node> m_node;

PseudoId m_pseudoElementSpecifier;

« Source/core/css/CSSBasicShapes.cpp ('K') | « Source/core/css/CSSCalculationValueTest.cpp ('k') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | Source/core/css/CSSValue.h » ('J')