Source/core/css/CSSCalculationValue.h - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSCalculationValue.h

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Some small fixes to (hopefully) fix some broken tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSCalculationValue.h

diff --git a/Source/core/css/CSSCalculationValue.h b/Source/core/css/CSSCalculationValue.h

index d79754fa29c1999f12111c0e4a917e21ad1a8a4c..36e79da4b45cfa9dd66060db53014f20b0614845 100644

--- a/Source/core/css/CSSCalculationValue.h

+++ b/Source/core/css/CSSCalculationValue.h

@@ -101,7 +101,7 @@ protected:

bool m_isInteger;

};

-class CORE_EXPORT CSSCalcValue : public CSSValue {

+class CORE_EXPORT CSSCalcValue : public CSSValueObject {

public:

static PassRefPtrWillBeRawPtr<CSSCalcValue> create(CSSParserValueList*, ValueRange);

static PassRefPtrWillBeRawPtr<CSSCalcValue> create(PassRefPtrWillBeRawPtr<CSSCalcExpressionNode>, ValueRange = ValueRangeAll);

@@ -132,7 +132,7 @@ public:

private:

CSSCalcValue(PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> expression, ValueRange range)

- : CSSValue(CalculationClass)

+ : CSSValueObject(CalculationClass)

, m_expression(expression)

, m_nonNegative(range == ValueRangeNonNegative)

{

« Source/core/css/CSSBasicShapes.cpp ('K') | « Source/core/css/CSSBorderImageSliceValue.cpp ('k') | Source/core/css/CSSCalculationValue.cpp » ('j') | Source/core/css/CSSValue.h » ('J')