CSSValue Immediates: Change CSSValue to an object instead of a pointer

Source/core/css/CSSBasicShapes.cpp

 /*
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above
  *    copyright notice, this list of conditions and the following
  *    disclaimer.
@@ skipping 275 matching lines @@
 bool CSSBasicShapePolygon::equals(const CSSBasicShape& shape) const
 {
     if (shape.type() != CSSBasicShapePolygonType)
         return false;
 
     const CSSBasicShapePolygon& rhs = toCSSBasicShapePolygon(shape);
 
     if (!compareCSSValuePtr(m_referenceBox, rhs.m_referenceBox))
         return false;
 
-    return compareCSSValueVector(m_values, rhs.m_values);
+    return compareCSSValueObjectVector(m_values, rhs.m_values);

[Timothy Loh, 2015/06/02 04:54:02]

OK, but you're going to have to make CSSBasicShapePolygon have a vector of
CSSValues before you can make CSSPrimitiveValues into immediates.

[sashab, 2015/06/05 06:16:28]

Yup; planning on doing all the primitive values etc in follow-up patches, I want
to keep this one as small as possible. Added a TODO to remove
compareCSSValueObjectVector to remind me about this specific case.

 }
 
 DEFINE_TRACE(CSSBasicShapePolygon)
 {
     visitor->trace(m_values);
     CSSBasicShape::trace(visitor);
 }
 
 static bool buildInsetRadii(Vector<String> &radii, const String& topLeftRadius, const String& topRightRadius, const String& bottomRightRadius, const String& bottomLeftRadius)
 {
@@ skipping 136 matching lines @@
     visitor->trace(m_left);
     visitor->trace(m_topLeftRadius);
     visitor->trace(m_topRightRadius);
     visitor->trace(m_bottomRightRadius);
     visitor->trace(m_bottomLeftRadius);
     CSSBasicShape::trace(visitor);
 }
 
 } // namespace blink