Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Some small fixes to (hopefully) fix some broken tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/css/CSSAnimatableValueFactory.cpp
diff --git a/Source/core/animation/css/CSSAnimatableValueFactory.cpp b/Source/core/animation/css/CSSAnimatableValueFactory.cpp
index abd9d8c51ef5f975efe67f65915e64d31ba6b226..8867732e9ce0d91c324ebedf37dd10cf1b5a3959 100644
--- a/Source/core/animation/css/CSSAnimatableValueFactory.cpp
+++ b/Source/core/animation/css/CSSAnimatableValueFactory.cpp
@@ -178,8 +178,7 @@ inline static PassRefPtrWillBeRawPtr<AnimatableValue> createFromLengthSize(const
inline static PassRefPtrWillBeRawPtr<AnimatableValue> createFromStyleImage(StyleImage* image)
{
if (image) {
- if (RefPtrWillBeRawPtr<CSSValue> cssValue = image->cssValue())
- return AnimatableImage::create(cssValue.release());
+ return AnimatableImage::create(CSSValue(image->cssValue()));
}
return AnimatableUnknown::create(CSSValueNone);
}

Powered by Google App Engine
This is Rietveld 408576698