Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Some small fixes to (hopefully) fix some broken tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/elements/styles/styles-new-API-expected.txt ('k') | Source/build/scripts/templates/StyleBuilder.cpp.tmpl » ('j') | Source/core/css/CSSBasicShapes.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp b/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

index 0cc9c9baddb22283131baef596a38da60d55adc2..7bebd274db97ad94be1f1dd276b8a4a9c61afded 100644

--- a/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

@@ -203,7 +203,7 @@ void V8CSSStyleDeclaration::namedPropertyGetterCustom(v8::Local<v8::Name> name,

CSSPropertyID resolvedProperty = resolveCSSPropertyID(unresolvedProperty);

CSSStyleDeclaration* impl = V8CSSStyleDeclaration::toImpl(info.Holder());

- RefPtrWillBeRawPtr<CSSValue> cssValue = impl->getPropertyCSSValueInternal(resolvedProperty);

+ NullableCSSValue cssValue = impl->getPropertyCSSValueInternal(resolvedProperty);

if (cssValue) {

v8SetReturnValueStringOrNull(info, cssValue->cssText(), info.GetIsolate());

return;