Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: Source/core/layout/svg/ReferenceFilterBuilder.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/svg/ReferenceFilterBuilder.cpp
diff --git a/Source/core/layout/svg/ReferenceFilterBuilder.cpp b/Source/core/layout/svg/ReferenceFilterBuilder.cpp
index dc4d3032acb910b6e92bb92c2c72051f936ccd93..f3bfcd1e67e16b3790695121b0982b726575d54a 100644
--- a/Source/core/layout/svg/ReferenceFilterBuilder.cpp
+++ b/Source/core/layout/svg/ReferenceFilterBuilder.cpp
@@ -76,10 +76,10 @@ static EColorInterpolation colorInterpolationForElement(SVGElement& element, ECo
// No layout has been performed, try to determine the property value
// "manually" (used by external SVG files.)
if (const StylePropertySet* propertySet = element.presentationAttributeStyle()) {
- RefPtrWillBeRawPtr<CSSValue> cssValue = propertySet->getPropertyCSSValue(CSSPropertyColorInterpolationFilters);
+ NullableCSSValue cssValue = propertySet->getPropertyCSSValue(CSSPropertyColorInterpolationFilters);
if (cssValue && cssValue->isPrimitiveValue()) {
- const CSSPrimitiveValue& primitiveValue = *((CSSPrimitiveValue*)cssValue.get());
- return static_cast<EColorInterpolation>(primitiveValue);
+ const CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(cssValue);
+ return static_cast<EColorInterpolation>(*primitiveValue);
}
}
// 'auto' is the default (per Filter Effects), but since the property is

Powered by Google App Engine
This is Rietveld 408576698