Source/core/html/HTMLHRElement.cpp - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLHRElement.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLHRElement.cpp

diff --git a/Source/core/html/HTMLHRElement.cpp b/Source/core/html/HTMLHRElement.cpp

index 7182a08f314a79892b209a1f94cd249fc2e7bb48..611a12f1afadac248401f3e6965a55e86680fdd9 100644

--- a/Source/core/html/HTMLHRElement.cpp

+++ b/Source/core/html/HTMLHRElement.cpp

@@ -75,7 +75,7 @@ void HTMLHRElement::collectStyleForPresentationAttribute(const QualifiedName& na

if (!hasAttribute(colorAttr)) {

addPropertyToPresentationAttributeStyle(style, CSSPropertyBorderStyle, CSSValueSolid);

- RefPtrWillBeRawPtr<CSSPrimitiveValue> darkGrayValue = cssValuePool().createColorValue(Color::darkGray);

+ CSSValue darkGrayValue = cssValuePool().createColorValue(Color::darkGray);

style->setProperty(CSSPropertyBorderColor, darkGrayValue);

style->setProperty(CSSPropertyBackgroundColor, darkGrayValue);

}

« Source/core/editing/EditorCommand.cpp ('K') | « Source/core/editing/markup.cpp ('k') | Source/core/layout/svg/ReferenceFilterBuilder.cpp » ('j') | no next file with comments »