Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1164563003: Extract device_sensors to /device via Mojofication (Closed)

Created:
5 years, 6 months ago by leonhsl(Using Gerrit)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, riju_, Michael van Ouwerkerk, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, mlamouri+watch-sensors_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract device_sensors to /device via Mojofication Mojofy /content/browser/device_sensors and extract it into /device to slim /content module. Also, Extract shared memory seqLock related codes from /content into /components/shared_memory_seqlock. Done: Linux gn/gyp build/run OK. Todo: unit_tests and browser_tests, Android/Win/IOS/ChromeOS build/run. IntentToImpl is discussed in https://groups.google.com/a/chromium.org/forum/#!topic/mojo-dev/wa_Wn3HWdFs TBR= BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1408 lines, -5241 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/components.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
A + components/shared_memory_seqlock.gypi View 1 chunk +6 lines, -5 lines 0 comments Download
A + components/shared_memory_seqlock/BUILD.gn View 1 chunk +9 lines, -6 lines 0 comments Download
A + components/shared_memory_seqlock/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A + components/shared_memory_seqlock/one_writer_seqlock.h View 3 chunks +6 lines, -7 lines 0 comments Download
A + components/shared_memory_seqlock/one_writer_seqlock.cc View 2 chunks +4 lines, -5 lines 0 comments Download
A + components/shared_memory_seqlock/one_writer_seqlock_unittest.cc View 4 chunks +7 lines, -8 lines 0 comments Download
A + components/shared_memory_seqlock/shared_memory_seqlock_buffer.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + components/shared_memory_seqlock/shared_memory_seqlock_reader.h View 3 chunks +19 lines, -17 lines 0 comments Download
A + components/shared_memory_seqlock/shared_memory_seqlock_reader.cc View 2 chunks +18 lines, -14 lines 0 comments Download
M content/browser/BUILD.gn View 5 chunks +1 line, -5 lines 0 comments Download
M content/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +2 lines, -2 lines 0 comments Download
D content/browser/device_sensors/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D content/browser/device_sensors/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D content/browser/device_sensors/ambient_light_mac.h View 1 chunk +0 lines, -40 lines 0 comments Download
D content/browser/device_sensors/ambient_light_mac.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D content/browser/device_sensors/data_fetcher_shared_memory.h View 1 chunk +0 lines, -84 lines 0 comments Download
D content/browser/device_sensors/data_fetcher_shared_memory_android.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D content/browser/device_sensors/data_fetcher_shared_memory_base.h View 1 chunk +0 lines, -102 lines 0 comments Download
D content/browser/device_sensors/data_fetcher_shared_memory_base.cc View 1 chunk +0 lines, -251 lines 0 comments Download
D content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc View 1 chunk +0 lines, -477 lines 0 comments Download
D content/browser/device_sensors/data_fetcher_shared_memory_chromeos.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D content/browser/device_sensors/data_fetcher_shared_memory_default.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D content/browser/device_sensors/data_fetcher_shared_memory_mac.cc View 1 chunk +0 lines, -259 lines 0 comments Download
D content/browser/device_sensors/data_fetcher_shared_memory_win.cc View 1 chunk +0 lines, -465 lines 0 comments Download
D content/browser/device_sensors/device_inertial_sensor_browsertest.cc View 1 chunk +0 lines, -336 lines 0 comments Download
D content/browser/device_sensors/device_inertial_sensor_service.h View 1 chunk +0 lines, -72 lines 0 comments Download
D content/browser/device_sensors/device_inertial_sensor_service.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D content/browser/device_sensors/device_light_message_filter.h View 1 chunk +0 lines, -33 lines 0 comments Download
D content/browser/device_sensors/device_light_message_filter.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D content/browser/device_sensors/device_motion_message_filter.h View 1 chunk +0 lines, -33 lines 0 comments Download
D content/browser/device_sensors/device_motion_message_filter.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D content/browser/device_sensors/device_orientation_message_filter.h View 1 chunk +0 lines, -33 lines 0 comments Download
D content/browser/device_sensors/device_orientation_message_filter.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D content/browser/device_sensors/inertial_sensor_consts.h View 1 chunk +0 lines, -36 lines 0 comments Download
D content/browser/device_sensors/sensor_manager_android.h View 1 chunk +0 lines, -126 lines 0 comments Download
D content/browser/device_sensors/sensor_manager_android.cc View 1 chunk +0 lines, -453 lines 0 comments Download
D content/browser/device_sensors/sensor_manager_android_unittest.cc View 1 chunk +0 lines, -164 lines 0 comments Download
D content/browser/device_sensors/sensor_manager_chromeos.h View 1 chunk +0 lines, -69 lines 0 comments Download
D content/browser/device_sensors/sensor_manager_chromeos.cc View 1 chunk +0 lines, -173 lines 0 comments Download
D content/browser/device_sensors/sensor_manager_chromeos_unittest.cc View 1 chunk +0 lines, -228 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +14 lines, -6 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/DEPS View 2 chunks +1 line, -2 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +0 lines, -3 lines 0 comments Download
D content/common/device_sensors/device_light_data.h View 1 chunk +0 lines, -23 lines 0 comments Download
D content/common/device_sensors/device_light_hardware_buffer.h View 1 chunk +0 lines, -17 lines 0 comments Download
D content/common/device_sensors/device_light_messages.h View 1 chunk +0 lines, -26 lines 0 comments Download
D content/common/device_sensors/device_motion_hardware_buffer.h View 1 chunk +0 lines, -18 lines 0 comments Download
D content/common/device_sensors/device_motion_messages.h View 1 chunk +0 lines, -28 lines 0 comments Download
D content/common/device_sensors/device_orientation_hardware_buffer.h View 1 chunk +0 lines, -18 lines 0 comments Download
D content/common/device_sensors/device_orientation_messages.h View 1 chunk +0 lines, -26 lines 0 comments Download
M content/common/gamepad_hardware_buffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
D content/common/one_writer_seqlock.h View 1 chunk +0 lines, -46 lines 0 comments Download
D content/common/one_writer_seqlock.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D content/common/one_writer_seqlock_unittest.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D content/common/shared_memory_seqlock_buffer.h View 1 chunk +0 lines, -30 lines 0 comments Download
M content/content_browser.gypi View 6 chunks +2 lines, -32 lines 0 comments Download
M content/content_common.gypi View 3 chunks +1 line, -5 lines 0 comments Download
M content/content_renderer.gypi View 3 chunks +3 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/device_sensors/device_light_event_pump.h View 3 chunks +9 lines, -13 lines 0 comments Download
M content/renderer/device_sensors/device_light_event_pump.cc View 3 chunks +18 lines, -27 lines 0 comments Download
M content/renderer/device_sensors/device_light_event_pump_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/device_sensors/device_motion_event_pump.h View 2 chunks +8 lines, -12 lines 0 comments Download
M content/renderer/device_sensors/device_motion_event_pump.cc View 2 chunks +24 lines, -25 lines 0 comments Download
M content/renderer/device_sensors/device_motion_event_pump_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/device_sensors/device_orientation_event_pump.h View 2 chunks +9 lines, -12 lines 0 comments Download
M content/renderer/device_sensors/device_orientation_event_pump.cc View 3 chunks +20 lines, -24 lines 0 comments Download
M content/renderer/device_sensors/device_orientation_event_pump_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/device_sensors/device_sensor_event_pump.h View 2 chunks +10 lines, -57 lines 0 comments Download
A content/renderer/device_sensors/device_sensor_event_pump.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 5 chunks +54 lines, -27 lines 0 comments Download
D content/renderer/shared_memory_seqlock_reader.h View 1 chunk +0 lines, -70 lines 0 comments Download
D content/renderer/shared_memory_seqlock_reader.cc View 1 chunk +0 lines, -60 lines 0 comments Download
A device/device_sensors/BUILD.gn View 1 chunk +92 lines, -0 lines 0 comments Download
A device/device_sensors/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A + device/device_sensors/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/device_sensors/ambient_light_mac.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + device/device_sensors/ambient_light_mac.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + device/device_sensors/data_fetcher_shared_memory.h View 5 chunks +13 lines, -13 lines 0 comments Download
A + device/device_sensors/data_fetcher_shared_memory_android.cc View 2 chunks +9 lines, -10 lines 0 comments Download
A + device/device_sensors/data_fetcher_shared_memory_base.h View 3 chunks +10 lines, -9 lines 0 comments Download
A + device/device_sensors/data_fetcher_shared_memory_base.cc View 11 chunks +25 lines, -27 lines 0 comments Download
A + device/device_sensors/data_fetcher_shared_memory_base_unittest.cc View 13 chunks +24 lines, -29 lines 0 comments Download
A + device/device_sensors/data_fetcher_shared_memory_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + device/device_sensors/data_fetcher_shared_memory_default.cc View 6 chunks +8 lines, -10 lines 0 comments Download
A + device/device_sensors/data_fetcher_shared_memory_mac.cc View 6 chunks +8 lines, -8 lines 0 comments Download
A + device/device_sensors/data_fetcher_shared_memory_win.cc View 15 chunks +89 lines, -101 lines 0 comments Download
A + device/device_sensors/device_inertial_sensor_browsertest.cc View 9 chunks +52 lines, -61 lines 0 comments Download
A + device/device_sensors/device_inertial_sensor_service.h View 5 chunks +11 lines, -11 lines 0 comments Download
A + device/device_sensors/device_inertial_sensor_service.cc View 6 chunks +13 lines, -9 lines 0 comments Download
A + device/device_sensors/device_light_data.h View 2 chunks +6 lines, -6 lines 0 comments Download
A device/device_sensors/device_light_hardware_buffer.h View 1 chunk +18 lines, -0 lines 0 comments Download
A device/device_sensors/device_motion_hardware_buffer.h View 1 chunk +18 lines, -0 lines 0 comments Download
A device/device_sensors/device_orientation_hardware_buffer.h View 1 chunk +18 lines, -0 lines 0 comments Download
A device/device_sensors/device_sensors.gyp View 1 chunk +126 lines, -0 lines 0 comments Download
A device/device_sensors/device_sensors.mojom View 1 chunk +36 lines, -0 lines 0 comments Download
A device/device_sensors/device_sensors_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
A device/device_sensors/device_sensors_light_impl.h View 1 chunk +43 lines, -0 lines 0 comments Download
A device/device_sensors/device_sensors_light_impl.cc View 1 chunk +66 lines, -0 lines 0 comments Download
A device/device_sensors/device_sensors_motion_impl.h View 1 chunk +43 lines, -0 lines 0 comments Download
A device/device_sensors/device_sensors_motion_impl.cc View 1 chunk +74 lines, -0 lines 0 comments Download
A device/device_sensors/device_sensors_orientation_impl.h View 1 chunk +43 lines, -0 lines 0 comments Download
A device/device_sensors/device_sensors_orientation_impl.cc View 1 chunk +68 lines, -0 lines 0 comments Download
A + device/device_sensors/inertial_sensor_consts.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + device/device_sensors/sensor_manager_android.h View 3 chunks +28 lines, -19 lines 0 comments Download
A + device/device_sensors/sensor_manager_android.cc View 14 chunks +42 lines, -32 lines 0 comments Download
A + device/device_sensors/sensor_manager_android_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + device/device_sensors/sensor_manager_chromeos.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + device/device_sensors/sensor_manager_chromeos.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + device/device_sensors/sensor_manager_chromeos_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A device/device_sensors/type_converters.h View 1 chunk +27 lines, -0 lines 0 comments Download
A device/device_sensors/type_converters.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
leonhsl(Using Gerrit)
This is a draft implementation and could you PTAL? If you think that it makes ...
5 years, 6 months ago (2015-05-29 11:05:02 UTC) #2
timvolodine
On 2015/05/29 11:05:02, leon.han wrote: > This is a draft implementation and could you PTAL? ...
5 years, 6 months ago (2015-05-29 12:22:16 UTC) #3
leonhsl(Using Gerrit)
Thanks timvolodine very much for review comments! Although this draft CL just employs Mojo MessagePipe, ...
5 years, 6 months ago (2015-06-02 02:57:18 UTC) #5
leonhsl(Using Gerrit)
Please hold review for this CL until I got a solution to employ Mojo SharedBuffer ...
5 years, 6 months ago (2015-06-02 11:44:13 UTC) #6
timvolodine
On 2015/06/02 11:44:13, leon.han wrote: > Please hold review for this CL until I got ...
5 years, 6 months ago (2015-06-03 12:09:19 UTC) #7
leonhsl(Using Gerrit)
On 2015/06/03 12:09:19, timvolodine wrote: > On 2015/06/02 11:44:13, leon.han wrote: > > Please hold ...
5 years, 6 months ago (2015-06-04 02:35:20 UTC) #8
leonhsl(Using Gerrit)
5 years, 5 months ago (2015-06-29 06:55:45 UTC) #9
progress update:
As for Mojo DataPipe, it's employing platform pipe underlying now, maybe employ
platform shared memory in future.
As for Mojo SharedBuffer, currently it can't support sandboxed process receiving
SharedBuffer handle which can be seen from RawChannelWin implementation.
RawChannelWin let receiver process duplicate the platform handle from peer
process but sandboxed process have no such duplicate permission. Obviously our
Renderer Process is sandboxed so we can't employ Mojo SharedBuffer for now.

Powered by Google App Engine
This is Rietveld 408576698