LayoutTests/fast/repaint/inline-outline-repaint-2-expected.txt - Issue 1164533005: Don't double-inflate visual overflow rect for LayoutInlines

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/repaint/inline-outline-repaint-2-expected.txt

Issue 1164533005: Don't double-inflate visual overflow rect for LayoutInlines (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: SP TEs. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/repaint/inline-outline-repaint-2.html ('K') | « LayoutTests/fast/repaint/inline-outline-repaint-2.html ('k') | Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "bounds": [800, 600],	2 "bounds": [800, 600],

3 "children": [	3 "children": [

4 {	4 {

5 "bounds": [800, 600],	5 "bounds": [800, 600],

6 "contentsOpaque": true,	6 "contentsOpaque": true,

7 "drawsContent": true,	7 "drawsContent": true,

8 "repaintRects": [	8 "repaintRects": [

9 [8, 8, 30, 30]	9 [215, 0, 40, 10],
	Julien - ping for review 2015/06/08 15:46:11 Why do we have this unneeded invalidation? Why do we have this unneeded invalidation? fs 2015/06/08 16:15:36 That's the LayoutText (shouldDoFullPaintInvalidati Show quoted text On 2015/06/08 15:46:11, Julien Chaffraix - PST wrote: > Why do we have this unneeded invalidation? That's the LayoutText (shouldDoFullPaintInvalidation() and layoutDidGetCalledSinceLastFrame() return true - reason is PaintInvalidationLayoutObjectInsertion) Can file a bug about it if you like. fs 2015/06/08 16:29:12 Uhm, make that PaintInvalidationStyleChange... Show quoted text On 2015/06/08 16:15:36, fs wrote: > On 2015/06/08 15:46:11, Julien Chaffraix - PST wrote: > > Why do we have this unneeded invalidation? > > ... reason is PaintInvalidationLayoutObjectInsertion Uhm, make that PaintInvalidationStyleChange... Julien - ping for review 2015/06/08 22:19:48 It's weird that we do 2 invalidations when we don' Show quoted text On 2015/06/08 at 16:29:12, fs wrote: > On 2015/06/08 16:15:36, fs wrote: > > On 2015/06/08 15:46:11, Julien Chaffraix - PST wrote: > > > Why do we have this unneeded invalidation? > > > > ... reason is PaintInvalidationLayoutObjectInsertion > > Uhm, make that PaintInvalidationStyleChange... It's weird that we do 2 invalidations when we don't move. We should just do a single one and that would suggest some rectangle being wrong so it's bug-worthy.
	10 [210, -5, 50, 20]

10 ]	11 ]

11 }	12 }

12 ]	13 ]

13 }	14 }

14	15

OLD	NEW