gin/shell/gin_main.cc - Issue 1164483003: Allow startup with missing V8 snapshot file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/shell/gin_main.cc

Issue 1164483003: Allow startup with missing V8 snapshot file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add natives_fd_exists and snapshot_fd_exists instead of checking for -1 Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/shell/gin_main.cc

diff --git a/gin/shell/gin_main.cc b/gin/shell/gin_main.cc

index d3bab721bebd82aa0d0741863a1d859c6919bab1..ee0755012068716a7d4d57d60f2b68e768c7525b 100644

--- a/gin/shell/gin_main.cc

+++ b/gin/shell/gin_main.cc

@@ -62,6 +62,7 @@ int main(int argc, char** argv) {

base::i18n::InitializeICU();

#ifdef V8_USE_EXTERNAL_STARTUP_DATA

gin::V8Initializer::LoadV8Snapshot();

+ gin::V8Initializer::LoadV8Natives();

#endif

gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,