Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gin/public/isolate_holder.h

Issue 1164483003: Allow startup with missing V8 snapshot file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add natives_fd_exists and snapshot_fd_exists instead of checking for -1 Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/shell/browser/shell_content_browser_client.cc ('K') | « extensions/shell/browser/shell_content_browser_client.cc ('k') | gin/shell/gin_main.cc » ('j') | gin/v8_initializer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/public/isolate_holder.h
diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h
index 111fde870f79af3979ab494317ef7c102f8b9126..ddd3aaa01145d21e4b19e58bde9ad15ed0615b71 100644
--- a/gin/public/isolate_holder.h
+++ b/gin/public/isolate_holder.h
@@ -40,7 +40,10 @@ class GIN_EXPORT IsolateHolder {
// Should be invoked once before creating IsolateHolder instances to
// initialize V8 and Gin. In case V8_USE_EXTERNAL_STARTUP_DATA is
- // defined, V8's initial snapshot should be loaded (by calling
+ // defined, V8's initial natives should be loaded (by calling
+ // V8Initializer::LoadV8NativesFromFD or
+ // V8Initializer::LoadV8Natives) before calling this method. If the
+ // snapshot file is available, it should also be loaded (by calling
// V8Initializer::LoadV8SnapshotFromFD or
// V8Initializer::LoadV8Snapshot) before calling this method.
static void Initialize(ScriptMode mode,
« content/shell/browser/shell_content_browser_client.cc ('K') | « extensions/shell/browser/shell_content_browser_client.cc ('k') | gin/shell/gin_main.cc » ('j') | gin/v8_initializer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698