chrome/browser/instant/instant_page.h - Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/instant/instant_page.h

Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/instant/instant_extended_browsertest.cc ('K') | « chrome/browser/instant/instant_extended_browsertest.cc ('k') | chrome/browser/instant/instant_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/instant/instant_page.h

diff --git a/chrome/browser/instant/instant_page.h b/chrome/browser/instant/instant_page.h

index 22565249edd20591b8a6336da9a73c0de8997d7a..fbd33e7589dbe708dc68a8d7fdb73dcdb8c1fec8 100644

--- a/chrome/browser/instant/instant_page.h

+++ b/chrome/browser/instant/instant_page.h

@@ -83,7 +83,8 @@ class InstantPage : public content::WebContentsObserver {

// Restricted IDs (rid in the API).

virtual void NavigateToURL(const content::WebContents* contents,

const GURL& url,

- content::PageTransition transition) = 0;

+ content::PageTransition transition,

+ WindowOpenDisposition disposition) = 0;

protected:

virtual ~Delegate();

@@ -204,8 +205,10 @@ class InstantPage : public content::WebContentsObserver {

InstantSizeUnits units);

void OnStartCapturingKeyStrokes(int page_id);

void OnStopCapturingKeyStrokes(int page_id);

- void OnSearchBoxNavigate(int page_id, const GURL& url,

- content::PageTransition transition);

+ void OnSearchBoxNavigate(int page_id,

+ const GURL& url,

+ content::PageTransition transition,

+ WindowOpenDisposition disposition);

Delegate* const delegate_;

bool supports_instant_;