chrome/browser/instant/instant_page.cc - Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/instant/instant_page.cc

Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/instant/instant_extended_browsertest.cc ('K') | « chrome/browser/instant/instant_page.h ('k') | chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/instant/instant_page.cc

diff --git a/chrome/browser/instant/instant_page.cc b/chrome/browser/instant/instant_page.cc

index a82a9c667bbfcd03beefbe19cc7745c837b7c7f1..97dd01832f8ad8bb3cb5dc46b79929eb3dc6f296 100644

--- a/chrome/browser/instant/instant_page.cc

+++ b/chrome/browser/instant/instant_page.cc

@@ -230,10 +230,11 @@ void InstantPage::OnStopCapturingKeyStrokes(int page_id) {

void InstantPage::OnSearchBoxNavigate(int page_id,

const GURL& url,

- content::PageTransition transition) {

+ content::PageTransition transition,

+ WindowOpenDisposition disposition) {

if (contents()->IsActiveEntry(page_id)) {

OnInstantSupportDetermined(page_id, true);

if (ShouldProcessNavigateToURL())

- delegate_->NavigateToURL(contents(), url, transition);

+ delegate_->NavigateToURL(contents(), url, transition, disposition);

}