Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1164263003: Don't set decomposed_transform_dirty_ bit dirty on appending Identity transform

Created:
5 years, 6 months ago by patro
Modified:
5 years, 6 months ago
Reviewers:
Ian Vollick, vivekg
CC:
chromium-reviews, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't set decomposed_transform_dirty_ bit dirty on appending Identity transform While appending identity transform, the |decomposed_transform_dirty_| bit need not be set as appending identity will not affect the decomposed transform. Adding a conditional check will prevent re-calculation of decomposed transform on appending identity transform. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M cc/animation/transform_operations.cc View 6 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
patro
5 years, 6 months ago (2015-06-08 12:58:01 UTC) #1
vivekg
This looks good to me. Can we have a unit test for this change?
5 years, 6 months ago (2015-06-09 14:32:27 UTC) #3
vivekg
Adding danakj@ who is one of the OWNERs of cc/
5 years, 6 months ago (2015-06-09 17:08:20 UTC) #5
danakj
5 years, 6 months ago (2015-06-09 17:13:10 UTC) #7
-danakj +vollick

Powered by Google App Engine
This is Rietveld 408576698