Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1164123003: Make createAttributeNS's qualifiedName argument non-nullable (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make createAttributeNS's qualifiedName argument non-nullable Before this change, document.createAttributeNS("foo", null) would throw "Failed to execute 'createAttributeNS' on 'Document': The qualified name provided is empty." because the null string was treated as empty. After this change, document.createAttributeNS("foo", null) will create an Attr object with localName "null", which matches Firefox and IE. Usage of this API is extremely low, making the risk equally so: https://www.chromestatus.com/metrics/feature/timeline/popularity/112 BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196940

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M LayoutTests/fast/dom/Document/createAttributeNS-namespace-err-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Document/script-tests/createAttributeNS-namespace-err.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/Document.idl View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164123003/20001
5 years, 6 months ago (2015-06-11 10:23:46 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-11 11:42:04 UTC) #4
philipj_slow
PTAL
5 years, 6 months ago (2015-06-11 11:44:07 UTC) #6
Jens Widell
LGTM
5 years, 6 months ago (2015-06-11 11:46:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164123003/20001
5 years, 6 months ago (2015-06-11 11:50:07 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 11:53:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196940

Powered by Google App Engine
This is Rietveld 408576698