Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: Source/core/dom/Document.idl

Issue 1164123003: Make createAttributeNS's qualifiedName argument non-nullable (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix test Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/dom/Document/script-tests/createAttributeNS-namespace-err.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.idl
diff --git a/Source/core/dom/Document.idl b/Source/core/dom/Document.idl
index 5ebbf1193b4b5b5263b07f1695ad3d83ce30db84..a27bc8a8b529bb5d5825558646f1f5656b279ed1 100644
--- a/Source/core/dom/Document.idl
+++ b/Source/core/dom/Document.idl
@@ -61,8 +61,7 @@ interface Document : Node {
[RaisesException, CustomElementCallbacks, TypeChecking=Interface] Node adoptNode(Node node);
[NewObject, RaisesException, MeasureAs=DocumentCreateAttribute] Attr createAttribute(DOMString localName);
- // FIXME: qualifiedName should not be nullable.
- [NewObject, RaisesException, MeasureAs=DocumentCreateAttributeNS] Attr createAttributeNS(DOMString? namespaceURI, DOMString? qualifiedName);
+ [NewObject, RaisesException, MeasureAs=DocumentCreateAttributeNS] Attr createAttributeNS(DOMString? namespaceURI, DOMString qualifiedName);
[NewObject, RaisesException] Event createEvent(DOMString eventType);
« no previous file with comments | « LayoutTests/fast/dom/Document/script-tests/createAttributeNS-namespace-err.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698