Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2108)

Unified Diff: chrome/browser/permissions/permission_context_uma_util.cc

Issue 1164073005: Allow script to request durable storage permission (chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ToT Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_uma_util.cc
diff --git a/chrome/browser/permissions/permission_context_uma_util.cc b/chrome/browser/permissions/permission_context_uma_util.cc
index d8d385134aee3f124b235067ba21900e2988c207..099d0b4a86260e96fac5780ce0e648d7c9974722 100644
--- a/chrome/browser/permissions/permission_context_uma_util.cc
+++ b/chrome/browser/permissions/permission_context_uma_util.cc
@@ -131,6 +131,13 @@ void RecordPermissionAction(ContentSettingsType permission,
action);
break;
#endif
+ case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE:
+ PERMISSION_ACTION_UMA( // Cargo culted
mlamouri (slow - plz ping) 2015/08/05 13:54:55 nit: remove Cargo culted comment.
dgrogan 2015/08/07 20:11:44 Done.
+ secure_origin, "ContentSettings.PermissionActions_DurableStorage",
+ "ContentSettings.PermissionActionsSecureOrigin_DurableStorage",
+ "ContentSettings.PermissionActionsInsecureOrigin_DurableStorage",
+ action);
+ break;
default:
NOTREACHED() << "PERMISSION " << permission << " not accounted for";
}
@@ -154,6 +161,8 @@ std::string PermissionTypeToString(PermissionType permission_type) {
return "Geolocation";
case PermissionType::PROTECTED_MEDIA_IDENTIFIER:
return "ProtectedMediaIdentifier";
+ case PermissionType::DURABLE_STORAGE:
+ return "DurableStorage";
case PermissionType::NUM:
break;
}
@@ -193,6 +202,9 @@ void RecordPermissionRequest(ContentSettingsType permission,
type = PermissionType::PROTECTED_MEDIA_IDENTIFIER;
break;
#endif
+ case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE:
+ type = content::PermissionType::DURABLE_STORAGE;
+ break;
default:
NOTREACHED() << "PERMISSION " << permission << " not accounted for";
return;

Powered by Google App Engine
This is Rietveld 408576698