Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chrome/browser/permissions/permission_context_uma_util.cc

Issue 1164073005: Allow script to request durable storage permission (chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ToT Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_context_uma_util.h" 5 #include "chrome/browser/permissions/permission_context_uma_util.h"
6 6
7 #include "base/metrics/histogram_macros.h" 7 #include "base/metrics/histogram_macros.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/permissions/permission_manager.h" 10 #include "chrome/browser/permissions/permission_manager.h"
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 #if defined(OS_ANDROID) || defined(OS_CHROMEOS) 124 #if defined(OS_ANDROID) || defined(OS_CHROMEOS)
125 case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER: 125 case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:
126 PERMISSION_ACTION_UMA( 126 PERMISSION_ACTION_UMA(
127 secure_origin, 127 secure_origin,
128 "ContentSettings.PermissionActions_ProtectedMedia", 128 "ContentSettings.PermissionActions_ProtectedMedia",
129 "ContentSettings.PermissionActionsSecureOrigin_ProtectedMedia", 129 "ContentSettings.PermissionActionsSecureOrigin_ProtectedMedia",
130 "ContentSettings.PermissionActionsInsecureOrigin_ProtectedMedia", 130 "ContentSettings.PermissionActionsInsecureOrigin_ProtectedMedia",
131 action); 131 action);
132 break; 132 break;
133 #endif 133 #endif
134 case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE:
135 PERMISSION_ACTION_UMA( // Cargo culted
mlamouri (slow - plz ping) 2015/08/05 13:54:55 nit: remove Cargo culted comment.
dgrogan 2015/08/07 20:11:44 Done.
136 secure_origin, "ContentSettings.PermissionActions_DurableStorage",
137 "ContentSettings.PermissionActionsSecureOrigin_DurableStorage",
138 "ContentSettings.PermissionActionsInsecureOrigin_DurableStorage",
139 action);
140 break;
134 default: 141 default:
135 NOTREACHED() << "PERMISSION " << permission << " not accounted for"; 142 NOTREACHED() << "PERMISSION " << permission << " not accounted for";
136 } 143 }
137 144
138 const std::string& rappor_metric = GetRapporMetric(permission, action); 145 const std::string& rappor_metric = GetRapporMetric(permission, action);
139 if (!rappor_metric.empty()) 146 if (!rappor_metric.empty())
140 rappor::SampleDomainAndRegistryFromGURL( 147 rappor::SampleDomainAndRegistryFromGURL(
141 g_browser_process->rappor_service(), rappor_metric, 148 g_browser_process->rappor_service(), rappor_metric,
142 requesting_origin); 149 requesting_origin);
143 } 150 }
144 151
145 std::string PermissionTypeToString(PermissionType permission_type) { 152 std::string PermissionTypeToString(PermissionType permission_type) {
146 switch (permission_type) { 153 switch (permission_type) {
147 case PermissionType::MIDI_SYSEX: 154 case PermissionType::MIDI_SYSEX:
148 return "MidiSysex"; 155 return "MidiSysex";
149 case PermissionType::PUSH_MESSAGING: 156 case PermissionType::PUSH_MESSAGING:
150 return "PushMessaging"; 157 return "PushMessaging";
151 case PermissionType::NOTIFICATIONS: 158 case PermissionType::NOTIFICATIONS:
152 return "Notifications"; 159 return "Notifications";
153 case PermissionType::GEOLOCATION: 160 case PermissionType::GEOLOCATION:
154 return "Geolocation"; 161 return "Geolocation";
155 case PermissionType::PROTECTED_MEDIA_IDENTIFIER: 162 case PermissionType::PROTECTED_MEDIA_IDENTIFIER:
156 return "ProtectedMediaIdentifier"; 163 return "ProtectedMediaIdentifier";
164 case PermissionType::DURABLE_STORAGE:
165 return "DurableStorage";
157 case PermissionType::NUM: 166 case PermissionType::NUM:
158 break; 167 break;
159 } 168 }
160 NOTREACHED(); 169 NOTREACHED();
161 return std::string(); 170 return std::string();
162 } 171 }
163 172
164 void RecordPermissionRequest(ContentSettingsType permission, 173 void RecordPermissionRequest(ContentSettingsType permission,
165 const GURL& requesting_origin, 174 const GURL& requesting_origin,
166 const GURL& embedding_origin, 175 const GURL& embedding_origin,
(...skipping 19 matching lines...) Expand all
186 type = PermissionType::MIDI_SYSEX; 195 type = PermissionType::MIDI_SYSEX;
187 break; 196 break;
188 case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING: 197 case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
189 type = PermissionType::PUSH_MESSAGING; 198 type = PermissionType::PUSH_MESSAGING;
190 break; 199 break;
191 #if defined(OS_ANDROID) || defined(OS_CHROMEOS) 200 #if defined(OS_ANDROID) || defined(OS_CHROMEOS)
192 case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER: 201 case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:
193 type = PermissionType::PROTECTED_MEDIA_IDENTIFIER; 202 type = PermissionType::PROTECTED_MEDIA_IDENTIFIER;
194 break; 203 break;
195 #endif 204 #endif
205 case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE:
206 type = content::PermissionType::DURABLE_STORAGE;
207 break;
196 default: 208 default:
197 NOTREACHED() << "PERMISSION " << permission << " not accounted for"; 209 NOTREACHED() << "PERMISSION " << permission << " not accounted for";
198 return; 210 return;
199 } 211 }
200 UMA_HISTOGRAM_ENUMERATION( 212 UMA_HISTOGRAM_ENUMERATION(
201 "ContentSettings.PermissionRequested", 213 "ContentSettings.PermissionRequested",
202 static_cast<base::HistogramBase::Sample>(type), 214 static_cast<base::HistogramBase::Sample>(type),
203 static_cast<base::HistogramBase::Sample>(PermissionType::NUM)); 215 static_cast<base::HistogramBase::Sample>(PermissionType::NUM));
204 if (secure_origin) { 216 if (secure_origin) {
205 UMA_HISTOGRAM_ENUMERATION( 217 UMA_HISTOGRAM_ENUMERATION(
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 275
264 void PermissionContextUmaUtil::PermissionDismissed( 276 void PermissionContextUmaUtil::PermissionDismissed(
265 ContentSettingsType permission, const GURL& requesting_origin) { 277 ContentSettingsType permission, const GURL& requesting_origin) {
266 RecordPermissionAction(permission, DISMISSED, requesting_origin); 278 RecordPermissionAction(permission, DISMISSED, requesting_origin);
267 } 279 }
268 280
269 void PermissionContextUmaUtil::PermissionIgnored( 281 void PermissionContextUmaUtil::PermissionIgnored(
270 ContentSettingsType permission, const GURL& requesting_origin) { 282 ContentSettingsType permission, const GURL& requesting_origin) {
271 RecordPermissionAction(permission, IGNORED, requesting_origin); 283 RecordPermissionAction(permission, IGNORED, requesting_origin);
272 } 284 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698