[es6] super.prop, eval and lazy functions

src/parser.cc

Index: src/parser.cc
diff --git a/src/parser.cc b/src/parser.cc
index a961f9140386b67cf84dbfb26b62341d37685dab..5c7ab396a56c97dcbf54b0eb5ccc7654cf5cd3d2 100644
--- a/src/parser.cc
+++ b/src/parser.cc
@@ -4103,7 +4103,7 @@ void Parser::SkipLazyFunctionBody(int* materialized_literal_count,
       *materialized_literal_count = entry.literal_count();
       *expected_property_count = entry.property_count();
       scope_->SetLanguageMode(entry.language_mode());
-      if (entry.uses_super_property()) scope_->RecordSuperPropertyUsage();
+      if (entry.needs_home_object()) scope_->RecordSuperPropertyUsage();

[adamk, 2015/06/04 20:02:33]

Maybe rename RecordSuperPropertyUsage() to something about HomeObject? I'll
admit "RecordNeedsHomeObject" doesn't sound great, though.

[arv (Not doing code reviews), 2015/06/04 20:15:57]

Yeah. This could be improved.

The Scope keeps track of both super.property and eval but the logging does not
keep 2 flags. So, when we recreate the Scope from the log we lost the calls_eval
flag (it gets set again in the eager parsing)

[arv (Not doing code reviews), 2015/06/04 20:48:26]

I changed it to use 2 fields in the logger instead. It is not required but it is
cleaner and straightforward.

       return;
     }
     cached_parse_data_->Reject();
@@ -4138,7 +4138,7 @@ void Parser::SkipLazyFunctionBody(int* materialized_literal_count,
   *materialized_literal_count = logger.literals();
   *expected_property_count = logger.properties();
   scope_->SetLanguageMode(logger.language_mode());
-  if (logger.scope_uses_super_property()) {
+  if (logger.needs_home_object()) {
     scope_->RecordSuperPropertyUsage();
   }
   if (produce_cached_parse_data()) {
@@ -4147,7 +4147,7 @@ void Parser::SkipLazyFunctionBody(int* materialized_literal_count,
     int body_end = scanner()->location().end_pos;
     log_->LogFunction(function_block_pos, body_end, *materialized_literal_count,
                       *expected_property_count, scope_->language_mode(),
-                      scope_->uses_super_property());
+                      scope_->NeedsHomeObject());
   }
 }