Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: src/preparse-data.h

Issue 1164073003: [es6] super.prop, eval and lazy functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Increment the preparse data version Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/preparse-data.h
diff --git a/src/preparse-data.h b/src/preparse-data.h
index 0cfef9125bcb1ecc84170bf6813f771791b58317..1dfc58810e8d83c372071ac216851c92dbbb74e7 100644
--- a/src/preparse-data.h
+++ b/src/preparse-data.h
@@ -54,7 +54,7 @@ class ParserRecorder {
// Logs the scope and some details of a function literal in the source.
virtual void LogFunction(int start, int end, int literals, int properties,
LanguageMode language_mode,
- bool uses_super_property) = 0;
+ bool needs_home_object) = 0;
// Logs an error message and marks the log as containing an error.
// Further logging will be ignored, and ExtractData will return a vector
@@ -77,15 +77,14 @@ class SingletonLogger : public ParserRecorder {
void Reset() { has_error_ = false; }
virtual void LogFunction(int start, int end, int literals, int properties,
- LanguageMode language_mode,
- bool scope_uses_super_property) {
+ LanguageMode language_mode, bool needs_home_object) {
DCHECK(!has_error_);
start_ = start;
end_ = end;
literals_ = literals;
properties_ = properties;
language_mode_ = language_mode;
- scope_uses_super_property_ = scope_uses_super_property;
+ needs_home_object_ = needs_home_object;
}
// Logs an error message and marks the log as containing an error.
@@ -118,9 +117,9 @@ class SingletonLogger : public ParserRecorder {
DCHECK(!has_error_);
return language_mode_;
}
- bool scope_uses_super_property() const {
+ bool needs_home_object() const {
DCHECK(!has_error_);
- return scope_uses_super_property_;
+ return needs_home_object_;
}
ParseErrorType error_type() const {
DCHECK(has_error_);
@@ -143,7 +142,7 @@ class SingletonLogger : public ParserRecorder {
int literals_;
int properties_;
LanguageMode language_mode_;
- bool scope_uses_super_property_;
+ bool needs_home_object_;
// For error messages.
MessageTemplate::Template message_;
const char* argument_opt_;
@@ -162,14 +161,13 @@ class CompleteParserRecorder : public ParserRecorder {
virtual ~CompleteParserRecorder() {}
virtual void LogFunction(int start, int end, int literals, int properties,
- LanguageMode language_mode,
- bool scope_uses_super_property) {
+ LanguageMode language_mode, bool needs_home_object) {
function_store_.Add(start);
function_store_.Add(end);
function_store_.Add(literals);
function_store_.Add(properties);
function_store_.Add(language_mode);
- function_store_.Add(scope_uses_super_property);
+ function_store_.Add(needs_home_object);
}
// Logs an error message and marks the log as containing an error.
« src/parser.cc ('K') | « src/parser.cc ('k') | src/preparse-data-format.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698