Implement SecurityHandler to send the lock icon status to DevTools.

content/browser/devtools/render_frame_devtools_agent_host.h

Index: content/browser/devtools/render_frame_devtools_agent_host.h
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.h b/content/browser/devtools/render_frame_devtools_agent_host.h
index a77cdbe2063f4825129d54bf3c21540cf3aa91f7..c853f7144a12e0e152be2324a9fe36434dfc377d 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.h
+++ b/content/browser/devtools/render_frame_devtools_agent_host.h
@@ -37,6 +37,9 @@ namespace inspector { class InspectorHandler; }
 namespace network { class NetworkHandler; }
 namespace page { class PageHandler; }
 namespace power { class PowerHandler; }
+namespace security {

[pfeldman, 2015/06/04 09:28:35]

maintain consistent code style?

[lgarron, 2015/06/05 01:29:18]

I thought I had fixed this. :-(

Oh well. Done.

+class SecurityHandler;
+}
 namespace service_worker { class ServiceWorkerHandler; }
 namespace tracing { class TracingHandler; }
 }
@@ -97,6 +100,7 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
       RenderFrameHost* render_frame_host,
       const GURL& url,
       ui::PageTransition transition_type) override;
+  void SecurityStyleChanged(content::SecurityStyle security_style) override;

[estark, 2015/06/04 01:09:15]

#include SecurityStyle in this file

[pfeldman, 2015/06/04 09:28:35]

How is this going to be called? RFDTAH is created lazily and security subsystem
would not know when to start notifying it. You should instead reverse this
dependency and add a stylechange listener upon SecurityHandler::enable.

[estark, 2015/06/04 14:35:27]

This is a WebContentsObserver method that gets called whenever the lock icon on
the page changes. (crrev.com/1162663004 is where the WebContentsObserver method
got added) I don't see why the lazy initialization of RFDTAH is a problem: it
looks like it's initialized when the dev tools window is toggled, at which point
we'll start getting these WebContentsObserver events. We've been following e.g.
PageHandler::DidAttachInterstitialPage as an example. Why is this different?

 
   void DisconnectRenderFrameHost();
   void ConnectRenderFrameHost(RenderFrameHost* rvh);
@@ -126,6 +130,7 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
   scoped_ptr<devtools::network::NetworkHandler> network_handler_;
   scoped_ptr<devtools::page::PageHandler> page_handler_;
   scoped_ptr<devtools::power::PowerHandler> power_handler_;
+  scoped_ptr<devtools::security::SecurityHandler> security_handler_;
   scoped_ptr<devtools::service_worker::ServiceWorkerHandler>
       service_worker_handler_;
   scoped_ptr<devtools::tracing::TracingHandler> tracing_handler_;