Implement SecurityHandler to send the lock icon status to DevTools.

content/browser/devtools/render_frame_devtools_agent_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DEVTOOLS_RENDER_FRAME_DEVTOOLS_AGENT_HOST_H_
 #define CONTENT_BROWSER_DEVTOOLS_RENDER_FRAME_DEVTOOLS_AGENT_HOST_H_
 
 #include <map>
 
 #include "base/basictypes.h"
@@ skipping 19 matching lines @@
 #endif
 
 namespace devtools {
 namespace dom { class DOMHandler; }
 namespace emulation { class EmulationHandler; }
 namespace input { class InputHandler; }
 namespace inspector { class InspectorHandler; }
 namespace network { class NetworkHandler; }
 namespace page { class PageHandler; }
 namespace power { class PowerHandler; }
+namespace security {

[pfeldman, 2015/06/04 09:28:35]

maintain consistent code style?

[lgarron, 2015/06/05 01:29:18]

I thought I had fixed this. :-(

Oh well. Done.

+class SecurityHandler;
+}
 namespace service_worker { class ServiceWorkerHandler; }
 namespace tracing { class TracingHandler; }
 }
 
 class CONTENT_EXPORT RenderFrameDevToolsAgentHost
     : public IPCDevToolsAgentHost,
       private WebContentsObserver {
  public:
   static void AddAllAgentHosts(DevToolsAgentHost::List* result);
 
@@ skipping 40 matching lines @@
   void RenderProcessGone(base::TerminationStatus status) override;
   bool OnMessageReceived(const IPC::Message& message,
                          RenderFrameHost* render_frame_host) override;
   bool OnMessageReceived(const IPC::Message& message) override;
   void DidAttachInterstitialPage() override;
   void DidDetachInterstitialPage() override;
   void DidCommitProvisionalLoadForFrame(
       RenderFrameHost* render_frame_host,
       const GURL& url,
       ui::PageTransition transition_type) override;
+  void SecurityStyleChanged(content::SecurityStyle security_style) override;

[estark, 2015/06/04 01:09:15]

#include SecurityStyle in this file

[pfeldman, 2015/06/04 09:28:35]

How is this going to be called? RFDTAH is created lazily and security subsystem
would not know when to start notifying it. You should instead reverse this
dependency and add a stylechange listener upon SecurityHandler::enable.

[estark, 2015/06/04 14:35:27]

This is a WebContentsObserver method that gets called whenever the lock icon on
the page changes. (crrev.com/1162663004 is where the WebContentsObserver method
got added) I don't see why the lazy initialization of RFDTAH is a problem: it
looks like it's initialized when the dev tools window is toggled, at which point
we'll start getting these WebContentsObserver events. We've been following e.g.
PageHandler::DidAttachInterstitialPage as an example. Why is this different?

 
   void DisconnectRenderFrameHost();
   void ConnectRenderFrameHost(RenderFrameHost* rvh);
   void ReattachToRenderFrameHost(RenderFrameHost* rvh);
 
   void SetRenderFrameHost(RenderFrameHost* rvh);
   void ClearRenderFrameHost();
 
   void RenderFrameCrashed();
   void OnSwapCompositorFrame(const IPC::Message& message);
   bool OnSetTouchEventEmulationEnabled(const IPC::Message& message);
 
   void OnDispatchOnInspectorFrontend(const DevToolsMessageChunk& message);
 
   void ClientDetachedFromRenderer();
 
   void InnerOnClientAttached();
   void InnerClientDetachedFromRenderer();
 
   bool IsChildFrame();
   void DestroyOnRenderFrameGone();
 
   RenderFrameHostImpl* render_frame_host_;
   scoped_ptr<devtools::dom::DOMHandler> dom_handler_;
   scoped_ptr<devtools::input::InputHandler> input_handler_;
   scoped_ptr<devtools::inspector::InspectorHandler> inspector_handler_;
   scoped_ptr<devtools::network::NetworkHandler> network_handler_;
   scoped_ptr<devtools::page::PageHandler> page_handler_;
   scoped_ptr<devtools::power::PowerHandler> power_handler_;
+  scoped_ptr<devtools::security::SecurityHandler> security_handler_;
   scoped_ptr<devtools::service_worker::ServiceWorkerHandler>
       service_worker_handler_;
   scoped_ptr<devtools::tracing::TracingHandler> tracing_handler_;
   scoped_ptr<devtools::emulation::EmulationHandler> emulation_handler_;
   scoped_ptr<DevToolsFrameTraceRecorder> frame_trace_recorder_;
 #if defined(OS_ANDROID)
   scoped_ptr<PowerSaveBlockerImpl> power_save_blocker_;
 #endif
   bool reattaching_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameDevToolsAgentHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DEVTOOLS_RENDER_FRAME_DEVTOOLS_AGENT_HOST_H_