Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: sky/sdk/lib/framework/components2/menu_divider.dart

Issue 1163913004: Implement menu_divider (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/examples/stocks2/lib/stock_app.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/components2/menu_divider.dart
diff --git a/sky/sdk/lib/framework/components2/menu_divider.dart b/sky/sdk/lib/framework/components2/menu_divider.dart
index de61104432c8b08cc04c7988fcc979b132401028..49e1af886421094a53dabae8e0aae37133ef2ba9 100644
--- a/sky/sdk/lib/framework/components2/menu_divider.dart
+++ b/sky/sdk/lib/framework/components2/menu_divider.dart
@@ -2,19 +2,21 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+import 'dart:sky' as sky;
import '../fn2.dart';
+import '../rendering/box.dart';
class MenuDivider extends Component {
- static final Style _style = new Style('''
- margin: 8px 0;
- border-bottom: 1px solid rgba(0, 0, 0, 0.12);'''
- );
+ static const sky.Color dividerColor = const sky.Color.fromARGB(31, 0, 0, 0);
abarth-chromium 2015/06/04 19:55:42 There's no need to do this if its const anyway.
jackson 2015/06/04 20:10:59 Done.
MenuDivider({ Object key }) : super(key: key);
UINode build() {
return new Container(
- style: _style
+ decoration: const BoxDecoration(
abarth-chromium 2015/06/04 19:55:42 The fact that this is const means it will be creat
jackson 2015/06/04 20:10:59 Done.
+ border: const Border(bottom: const BorderSide(color: dividerColor))
+ ),
+ margin: const EdgeDims.symmetric(vertical: 8.0)
);
}
}
« no previous file with comments | « sky/examples/stocks2/lib/stock_app.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698